From a53de5827cbccda145c4d7bcc024adf47fbcb9fa Mon Sep 17 00:00:00 2001
From: Kevin Franklin Kim <kevin.kim@bestbytes.com>
Date: Fri, 16 May 2025 23:28:28 +0200
Subject: [PATCH] fix: log

---
 client/client_test.go | 9 +++++++--
 pkg/handler/socket.go | 2 +-
 2 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/client/client_test.go b/client/client_test.go
index 2219537..f0bd9e9 100644
--- a/client/client_test.go
+++ b/client/client_test.go
@@ -17,6 +17,7 @@ import (
 
 func TestUpdate(t *testing.T) {
 	testWithClients(t, func(t *testing.T, c *client.Client) {
+		t.Helper()
 		response, err := c.Update(t.Context())
 		require.NoError(t, err)
 		require.True(t, response.Success, "update has to return .Sucesss true")
@@ -27,6 +28,7 @@ func TestUpdate(t *testing.T) {
 
 func TestGetURIs(t *testing.T) {
 	testWithClients(t, func(t *testing.T, c *client.Client) {
+		t.Helper()
 		request := mock.MakeValidURIsRequest()
 		uriMap, err := c.GetURIs(t.Context(), request.Dimension, request.IDs)
 		time.Sleep(100 * time.Millisecond)
@@ -37,6 +39,7 @@ func TestGetURIs(t *testing.T) {
 
 func TestGetRepo(t *testing.T) {
 	testWithClients(t, func(t *testing.T, c *client.Client) {
+		t.Helper()
 		r, err := c.GetRepo(t.Context())
 		require.NoError(t, err)
 		if assert.NotEmpty(t, r, "received empty JSON from GetRepo") {
@@ -47,6 +50,7 @@ func TestGetRepo(t *testing.T) {
 
 func TestGetNodes(t *testing.T) {
 	testWithClients(t, func(t *testing.T, c *client.Client) {
+		t.Helper()
 		nodesRequest := mock.MakeNodesRequest()
 		nodes, err := c.GetNodes(t.Context(), nodesRequest.Env, nodesRequest.Nodes)
 		require.NoError(t, err)
@@ -66,6 +70,7 @@ func TestGetNodes(t *testing.T) {
 
 func TestGetContent(t *testing.T) {
 	testWithClients(t, func(t *testing.T, c *client.Client) {
+		t.Helper()
 		request := mock.MakeValidContentRequest()
 		response, err := c.GetContent(t.Context(), request)
 		require.NoError(t, err)
@@ -119,10 +124,10 @@ func testWithClients(t *testing.T, testFunc func(t *testing.T, c *client.Client)
 	httpClient := newHTTPClient(t, httpRepoServer)
 	socketClient := newSocketClient(t, socketRepoServer.Addr().String())
 	defer func() {
-		httpRepoServer.Close()
-		socketRepoServer.Close()
 		httpClient.Close()
 		socketClient.Close()
+		httpRepoServer.Close()
+		socketRepoServer.Close()
 	}()
 	testFunc(t, httpClient)
 	testFunc(t, socketClient)
diff --git a/pkg/handler/socket.go b/pkg/handler/socket.go
index 0820dfa..bc9a5b6 100644
--- a/pkg/handler/socket.go
+++ b/pkg/handler/socket.go
@@ -67,7 +67,7 @@ func (h *Socket) Serve(conn net.Conn) {
 		// let us read with 1 byte steps on conn until we find "{"
 		_, readErr := conn.Read(headerBuffer[0:])
 		if readErr != nil {
-			h.l.Debug("looks like the client closed the connection", zap.Error(readErr))
+			// h.l.Debug("looks like the client closed the connection", zap.Error(readErr))
 			metrics.NumSocketsGauge.WithLabelValues(conn.RemoteAddr().String()).Dec()
 			return
 		}