From b4f8b95a4be2ad883c2ba5045f5c0b0f8a264fe7 Mon Sep 17 00:00:00 2001 From: Kevin Franklin Kim Date: Fri, 22 Mar 2024 16:30:54 +0100 Subject: [PATCH] refactor: rename onLoaded --- client/client_test.go | 2 +- cmd/socket.go | 2 +- pkg/repo/loader.go | 4 ++-- pkg/repo/repo.go | 6 +++--- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/client/client_test.go b/client/client_test.go index 7543f0b..e4c1f5e 100644 --- a/client/client_test.go +++ b/client/client_test.go @@ -130,7 +130,7 @@ func initRepo(tb testing.TB, l *zap.Logger) *repo.Repo { ), ) up := make(chan bool, 1) - r.OnStart(func() { + r.OnLoaded(func() { up <- true }) go r.Start(context.TODO()) //nolint:errcheck diff --git a/cmd/socket.go b/cmd/socket.go index 88b45f1..d89b870 100644 --- a/cmd/socket.go +++ b/cmd/socket.go @@ -57,7 +57,7 @@ func NewSocketCommand() *cobra.Command { // start repo up := make(chan bool, 1) - r.OnStart(func() { + r.OnLoaded(func() { up <- true }) go r.Start(context.Background()) //nolint:errcheck diff --git a/pkg/repo/loader.go b/pkg/repo/loader.go index 47551b6..36e55b3 100644 --- a/pkg/repo/loader.go +++ b/pkg/repo/loader.go @@ -68,8 +68,8 @@ func (r *Repo) UpdateRoutine(ctx context.Context) error { if !r.Loaded() { r.loaded.Store(true) l.Info("initial update success") - if r.onStart != nil { - r.onStart() + if r.onLoaded != nil { + r.onLoaded() } } else { l.Info("update success") diff --git a/pkg/repo/repo.go b/pkg/repo/repo.go index a920b5e..b1e7565 100644 --- a/pkg/repo/repo.go +++ b/pkg/repo/repo.go @@ -31,7 +31,7 @@ type ( poll bool pollInterval time.Duration pollVersion string - onStart func() + onLoaded func() loaded *atomic.Bool history *History httpClient *http.Client @@ -130,8 +130,8 @@ func (r *Repo) SetJSONBuffer(v *bytes.Buffer) { // ~ Public methods // ------------------------------------------------------------------------------------------------ -func (r *Repo) OnStart(fn func()) { - r.onStart = fn +func (r *Repo) OnLoaded(fn func()) { + r.onLoaded = fn } // GetURIs get many uris at once