mirror of
https://github.com/foomo/foomo-docs.git
synced 2025-10-16 12:35:40 +00:00
add blog post about accuracy of decimal computations
This commit is contained in:
parent
fa94e3fd55
commit
f624bf36d1
1
foomo/.gitignore
vendored
1
foomo/.gitignore
vendored
@ -19,3 +19,4 @@
|
||||
npm-debug.log*
|
||||
yarn-debug.log*
|
||||
yarn-error.log*
|
||||
pnpm-lock.yaml
|
||||
|
||||
Binary file not shown.
|
After Width: | Height: | Size: 18 KiB |
@ -0,0 +1,77 @@
|
||||
---
|
||||
slug: accuracy-of-decimal-computations
|
||||
authors: [patrickb]
|
||||
tags: [golang, currency, decimal accuracy]
|
||||
---
|
||||
|
||||
# Accuracy of decimal computations
|
||||
|
||||
## Intro
|
||||
|
||||
Calculating with money can be tricky if not taken proper precautions. Some might be tempted to use float representation for calculating with currency values. That is problematic because of possible rounding errors.
|
||||
|
||||
## Finite accuracy of representation
|
||||
|
||||
Floating points are represented like this
|
||||
|
||||

|
||||
|
||||
Not every number can be represented with a finite number of decimal places
|
||||
|
||||
0.01 —> 0.0000011001100110011…
|
||||
|
||||
Taking 17 places of the above results in 0.010000000000000001
|
||||
|
||||
Consider the following code snipet that shows the missing accuracy
|
||||
|
||||
```go
|
||||
func main() {
|
||||
|
||||
var n float64 = 0
|
||||
|
||||
for i := 0; i < 1000; i++ {
|
||||
n += .01
|
||||
}
|
||||
|
||||
fmt.Println(n)
|
||||
|
||||
}
|
||||
```
|
||||
|
||||
Result: 9.999999999999831
|
||||
|
||||
## Money computations
|
||||
|
||||
They can't be done with floating-point as it would inevitably lead to rounding errors.
|
||||
|
||||
Even the following packages are problematic:
|
||||
|
||||
[github.com/shopspring/decimal](https://github.com/shopspring/decimal)
|
||||
|
||||
[github.com/Rhymond/go-money](https://github.com/Rhymond/go-money)
|
||||
|
||||
```go
|
||||
a := decimal.NewFromInt(2)
|
||||
b := decimal.NewFromFloat(300.99)
|
||||
c := a.Mul(b)
|
||||
d := c.Div(decimal.NewFromInt(3))
|
||||
```
|
||||
|
||||
## Solution
|
||||
|
||||
Use Int by representing money in cents:
|
||||
|
||||
- 10.99 -> 1099 (cents)
|
||||
- 10.9900 -> 109900 (4 digit tax)
|
||||
|
||||
## Conclusio
|
||||
|
||||
Division is a problem!
|
||||
|
||||
1/3 - > 0.33333333…
|
||||
Correct way: 0.33, 0.33, 0.34
|
||||
|
||||
When doing money calculations one should avoid division as it inevitably leads to loss of accuracy.
|
||||
When dividing make sure to round to cent and deal with diffs.
|
||||
|
||||
Division by 10^k is ok till we are inside of the range of the data type.
|
||||
@ -23,3 +23,8 @@ nicola:
|
||||
title: Memelord brother
|
||||
url: https://github.com/nicolaturcato
|
||||
image_url: https://github.com/nicolaturcato.png
|
||||
patrickb:
|
||||
name: Patrick Buchner
|
||||
title: MSc
|
||||
url: https://github.com/smartinov
|
||||
image_url: https://github.com/uebriges.png
|
||||
|
||||
Loading…
Reference in New Issue
Block a user