foomo/gofuncy
1
0
Fork 0
mirror of https://github.com/foomo/gofuncy.git synced 2025-10-16 12:25:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix: completed metric

Browse Source
This commit is contained in:
Kevin Franklin Kim 2025-05-13 09:03:28 +02:00
parent 441ac40f05
commit 1f73b4af65
No known key found for this signature in database
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
go.go
View File

@ -11,6 +11,7 @@ import (
"github.com/Ju0x/humanhash" "github.com/Ju0x/humanhash"
"go.opentelemetry.io/otel" "go.opentelemetry.io/otel"
"go.opentelemetry.io/otel/attribute" "go.opentelemetry.io/otel/attribute"
"go.opentelemetry.io/otel/codes"
"go.opentelemetry.io/otel/metric" "go.opentelemetry.io/otel/metric"
semconv "go.opentelemetry.io/otel/semconv/v1.30.0" semconv "go.opentelemetry.io/otel/semconv/v1.30.0"
"go.opentelemetry.io/otel/trace" "go.opentelemetry.io/otel/trace"
@ -180,7 +181,13 @@ func Go(fn Func, opts ...Option) <-chan error {
if span.IsRecording() { if span.IsRecording() {
l = l.With(zap.String("trace_id", span.SpanContext().TraceID().String())) l = l.With(zap.String("trace_id", span.SpanContext().TraceID().String()))
} }
defer span.End() defer func() {
if err != nil {
span.RecordError(err)
span.SetStatus(codes.Error, err.Error())
}
span.End()
}()
} }
l.Log(o.level, "starting gofuncy routine", l.Log(o.level, "starting gofuncy routine",
zap.Duration("delay", time.Since(delay).Round(time.Millisecond)), zap.Duration("delay", time.Since(delay).Round(time.Millisecond)),
@ -198,8 +205,7 @@ func Go(fn Func, opts ...Option) <-chan error {
defer o.runningCounter.Add(ctx, -1, attrs) defer o.runningCounter.Add(ctx, -1, attrs)
} }
if o.completedCounter != nil { if o.completedCounter != nil {
o.completedCounter.Add(ctx, 1, attrs) defer o.runningCounter.Add(ctx, 1, attrs, metric.WithAttributes(
defer o.runningCounter.Add(ctx, -1, attrs, metric.WithAttributes(
attribute.Bool("error", err != nil), attribute.Bool("error", err != nil),
)) ))
} }