From 6e6dca86c870a9e21c022ff37f27eee84532caf3 Mon Sep 17 00:00:00 2001 From: Kevin Franklin Kim Date: Wed, 18 Oct 2023 16:37:11 +0200 Subject: [PATCH] fix: pass provider --- option.go | 2 +- service/httpreadme.go | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/option.go b/option.go index 7fad21f..b00a486 100644 --- a/option.go +++ b/option.go @@ -183,7 +183,7 @@ func WithHTTPHealthzService(enabled bool) Option { func WithHTTPReadmeService(enabled bool) Option { return func(inst *Server) { if config.GetBool(inst.Config(), "service.readme.enabled", enabled)() { - svs := service.NewDefaultHTTPReadme(inst.Logger(), &inst.readmers) + svs := service.NewDefaultHTTPReadme(inst.Logger(), inst.readmers) inst.initServices = append(inst.initServices, svs) inst.AddAlwaysHealthzers(svs) } diff --git a/service/httpreadme.go b/service/httpreadme.go index 3cb5026..967173a 100644 --- a/service/httpreadme.go +++ b/service/httpreadme.go @@ -14,7 +14,7 @@ const ( DefaultHTTPReadmePath = "/readme" ) -func NewHTTPReadme(l *zap.Logger, name, addr, path string, readmers *[]interfaces.Readmer) *HTTP { +func NewHTTPReadme(l *zap.Logger, name, addr, path string, readmers func() []interfaces.Readmer) *HTTP { handler := http.NewServeMux() handler.HandleFunc(path, func(w http.ResponseWriter, r *http.Request) { switch r.Method { @@ -22,7 +22,7 @@ func NewHTTPReadme(l *zap.Logger, name, addr, path string, readmers *[]interface w.Header().Add("Content-Type", "text/markdown") w.WriteHeader(http.StatusOK) md := &markdown.Markdown{} - for _, readmer := range *readmers { + for _, readmer := range readmers() { md.Print(readmer.Readme()) } _, _ = w.Write([]byte(md.String())) @@ -33,7 +33,7 @@ func NewHTTPReadme(l *zap.Logger, name, addr, path string, readmers *[]interface return NewHTTP(l, name, addr, handler) } -func NewDefaultHTTPReadme(l *zap.Logger, readmers *[]interfaces.Readmer) *HTTP { +func NewDefaultHTTPReadme(l *zap.Logger, readmers func() []interfaces.Readmer) *HTTP { return NewHTTPReadme( l, DefaultHTTPReadmeName,