From d95f8df187ad8edcb53b1695467b274263c2fb2d Mon Sep 17 00:00:00 2001 From: Kevin Franklin Kim Date: Mon, 26 May 2025 21:54:45 +0200 Subject: [PATCH] chore: bump golangci-lint --- .github/workflows/pr.yml | 2 +- .golangci.yml | 218 ++++++++++++++++++++------------------- .husky.yaml | 4 +- 3 files changed, 116 insertions(+), 108 deletions(-) diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml index 619b89a..d3fe4c0 100644 --- a/.github/workflows/pr.yml +++ b/.github/workflows/pr.yml @@ -25,7 +25,7 @@ jobs: with: token: ${{ secrets.GITHUB_TOKEN }} - - uses: golangci/golangci-lint-action@v6 + - uses: golangci/golangci-lint-action@v8 with: args: --timeout=10m version: latest diff --git a/.golangci.yml b/.golangci.yml index 864dbb1..0d5a56c 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -1,109 +1,13 @@ -# yaml-language-server: $schema=https://golangci-lint.run/jsonschema/golangci.jsonschema.json -# https://golangci-lint.run/usage/configuration/ - +version: "2" run: go: 1.23.0 - build-tags: [safe] + build-tags: [ safe ] modules-download-mode: readonly - -issues: - exclude-dirs: - - 'bin' - - 'tmp' - exclude-rules: - - path: _test\.go - linters: - - forcetypeassert - - gocheckcompilerdirectives - -linters-settings: - # https://golangci-lint.run/usage/linters/#misspell - misspell: - mode: restricted - # https://golangci-lint.run/usage/linters/#asasalint - asasalint: - ignore-test: true - # https://golangci-lint.run/usage/linters/#exhaustive - exhaustive: - default-signifies-exhaustive: true - # https://golangci-lint.run/usage/linters/#gocritic - gocritic: - disabled-checks: - - assignOp - - ifElseChain - # https://golangci-lint.run/usage/linters/#testifylint - testifylint: - disable: - - float-compare - # https://golangci-lint.run/usage/linters/#gosec - gosec: - confidence: medium - # https://golangci-lint.run/usage/linters/#revive - revive: - enable-all-rules: true - ignore-generated-header: true - rules: - - name: line-length-limit - disabled: true - - name: cognitive-complexity - disabled: true - - name: unused-parameter - disabled: true - - name: add-constant - disabled: true - - name: indent-error-flow - disabled: true - - name: cyclomatic - disabled: true - - name: function-length - disabled: true - - name: use-any - disabled: true - - name: max-public-structs - disabled: true - - name: function-result-limit - disabled: true - - name: flag-parameter - disabled: true - - name: unused-receiver - disabled: true - - name: argument-limit - disabled: true - - name: empty-lines - disabled: true - - name: confusing-results - disabled: true - - name: max-control-nesting - disabled: true - - name: comment-spacings - disabled: true - - name: struct-tag - arguments: - - "json,inline" - - name: unhandled-error - arguments: - - "fmt.Printf" - - "fmt.Println" - # TODO remove - - name: exported - disabled: true - - name: empty-block - disabled: true - - name: early-return - disabled: true - - name: confusing-naming - disabled: true - - name: superfluous-else - disabled: true - - name: unexported-return - disabled: true - linters: - disable-all: true + default: none enable: ## Default linters - errcheck # errcheck is a program for checking for unchecked errors in Go code. These unchecked errors can be critical bugs in some cases [fast: false, auto-fix: false] - - gosimple # (megacheck) Linter for Go source code that specializes in simplifying code [fast: false, auto-fix: false] - govet # (vet, vetshadow) Vet examines Go source code and reports suspicious constructs. It is roughly the same as 'go vet' and uses its passes. [fast: false, auto-fix: false] - ineffassign # Detects when assignments to existing variables are not used [fast: true, auto-fix: false] - staticcheck # (megacheck) It's a set of rules from staticcheck. It's not the same thing as the staticcheck binary. The author of staticcheck doesn't support or approve the use of staticcheck as a library inside golangci-lint. [fast: false, auto-fix: false] @@ -132,9 +36,7 @@ linters: - gochecksumtype # Run exhaustiveness checks on Go "sum types" [fast: false, auto-fix: false] #- goconst # Finds repeated strings that could be replaced by a constant [fast: true, auto-fix: false] - gocritic # Provides diagnostics that check for bugs, performance and style issues. [fast: false, auto-fix: true] - - gofmt # Gofmt checks whether code was gofmt-ed. By default this tool runs with -s option to check for code simplification [fast: true, auto-fix: true] - goheader # Checks is file header matches to pattern [fast: true, auto-fix: true] - - goimports # Check import statements are formatted according to the 'goimport' command. Reformat imports in autofix mode. [fast: true, auto-fix: true] - gomoddirectives # Manage the use of 'replace', 'retract', and 'excludes' directives in go.mod. [fast: true, auto-fix: false] - gomodguard # Allow and block list linter for direct Go module dependencies. This is different from depguard where there are different block types for example version constraints and module recommendations. [fast: true, auto-fix: false] - goprintffuncname # Checks that printf-like functions are named with `f` at the end. [fast: true, auto-fix: false] @@ -166,11 +68,10 @@ linters: - rowserrcheck # checks whether Rows.Err of rows is checked successfully [fast: false, auto-fix: false] - spancheck # Checks for mistakes with OpenTelemetry/Census spans. [fast: false, auto-fix: false] - sqlclosecheck # Checks that sql.Rows, sql.Stmt, sqlx.NamedStmt, pgx.Query are closed. [fast: false, auto-fix: false] - - stylecheck # Stylecheck is a replacement for golint [fast: false, auto-fix: false] - testableexamples # linter checks if examples are testable (have an expected output) [fast: true, auto-fix: false] - testifylint # Checks usage of github.com/stretchr/testify. [fast: false, auto-fix: false] - testpackage # linter that makes you use a separate _test package [fast: true, auto-fix: false] - - thelper # thelper detects tests helpers which is not start with t.Helper() method. [fast: false, auto-fix: false] + #- thelper # thelper detects tests helpers which is not start with t.Helper() method. [fast: false, auto-fix: false] #- tparallel # tparallel detects inappropriate usage of t.Parallel() method in your Go test codes. [fast: false, auto-fix: false] - unconvert # Remove unnecessary type conversions [fast: false, auto-fix: false] - usestdlibvars # A linter that detect the possibility to use variables/constants from the Go standard library. [fast: true, auto-fix: false] @@ -188,7 +89,6 @@ linters: #- err113 # Go linter to check the errors handling expressions [fast: false, auto-fix: false] #- exhaustruct # Checks if all structure fields are initialized [fast: false, auto-fix: false] #- funlen # Tool for detection of long functions [fast: true, auto-fix: false] - #- gci # Gci controls Go package import order and makes it always deterministic. [fast: true, auto-fix: true] #- ginkgolinter # enforces standards of using ginkgo and gomega [fast: false, auto-fix: false] #- gochecknoglobals # Check that no global variables exist. [fast: false, auto-fix: false] #- gochecknoinits # Checks that no init functions are present in Go code [fast: true, auto-fix: false] @@ -196,7 +96,6 @@ linters: #- gocyclo # Computes and checks the cyclomatic complexity of functions [fast: true, auto-fix: false] #- godot # Check if comments end in a period [fast: true, auto-fix: true] #- godox # Tool for detection of comment keywords [fast: true, auto-fix: false] - #- gofumpt # Gofumpt checks whether code was gofumpt-ed. [fast: true, auto-fix: true] #- interfacebloat # A linter that checks the number of methods inside an interface. [fast: true, auto-fix: false] #- intrange # (go >= 1.22) intrange is a linter to find places where for loops could make use of an integer range. [fast: true, auto-fix: false] #- ireturn # Accept Interfaces, Return Concrete Types [fast: false, auto-fix: false] @@ -216,3 +115,112 @@ linters: #- wrapcheck # Checks that errors returned from external packages are wrapped [fast: false, auto-fix: false] #- wsl # add or remove empty lines [fast: true, auto-fix: false] #- zerologlint # Detects the wrong usage of `zerolog` that a user forgets to dispatch with `Send` or `Msg` [fast: false, auto-fix: false] + settings: + staticcheck: + checks: + - all + - -QF1003 + - -QF1006 + - -QF1008 + exhaustive: + default-signifies-exhaustive: true + gocritic: + disabled-checks: + - assignOp + - ifElseChain + gosec: + confidence: medium + misspell: + mode: restricted + revive: + enable-all-rules: true + rules: + - name: line-length-limit + disabled: true + - name: cognitive-complexity + disabled: true + - name: unused-parameter + disabled: true + - name: add-constant + disabled: true + - name: indent-error-flow + disabled: true + - name: cyclomatic + disabled: true + - name: function-length + disabled: true + - name: use-any + disabled: true + - name: max-public-structs + disabled: true + - name: function-result-limit + disabled: true + - name: flag-parameter + disabled: true + - name: unused-receiver + disabled: true + - name: argument-limit + disabled: true + - name: empty-lines + disabled: true + - name: confusing-results + disabled: true + - name: max-control-nesting + disabled: true + - name: comment-spacings + disabled: true + - name: struct-tag + arguments: + - json,inline + - name: unhandled-error + arguments: + - fmt.Printf + - fmt.Println + - name: exported + disabled: true + - name: empty-block + disabled: true + - name: early-return + disabled: true + - name: confusing-naming + disabled: true + - name: superfluous-else + disabled: true + - name: unexported-return + disabled: true + testifylint: + disable: + - float-compare + exclusions: + generated: lax + presets: + - comments + - common-false-positives + - legacy + - std-error-handling + rules: + - linters: + - forcetypeassert + - gocheckcompilerdirectives + path: _test\.go + - linters: + - asasalint + path: (.+)_test\.go + paths: + - bin + - tmp + - third_party$ + - builtin$ + - examples +formatters: + enable: + - gofmt + - goimports + exclusions: + generated: lax + paths: + - bin + - tmp + - third_party$ + - builtin$ + - examples$ diff --git a/.husky.yaml b/.husky.yaml index 2bbd935..0284970 100644 --- a/.husky.yaml +++ b/.husky.yaml @@ -1,6 +1,6 @@ hooks: pre-commit: - - golangci-lint run --fast + - golangci-lint run --fast-only - husky lint-staged commit-msg: # only execute if not in a merge @@ -8,7 +8,7 @@ hooks: lint-staged: '*.go': - - goimports -l -w + - golangci-lint fmt lint-commit: types: '^(feat|fix|build|chore|docs|perf|refactor|revert|style|test|wip)$'