feat: bump golangci-lint

.github/workflows/test.yml

@@ -25,7 +25,7 @@ jobs:
         with:
           token: ${{ secrets.GITHUB_TOKEN }}
 
-      - uses: golangci/golangci-lint-action@v6
+      - uses: golangci/golangci-lint-action@v7
         with:
           version: latest
 

.golangci.yml

@@ -1,124 +1,14 @@
-# yaml-language-server: $schema=https://golangci-lint.run/jsonschema/golangci.jsonschema.json
-# https://golangci-lint.run/usage/configuration/
-
+version: "2"
 run:
   go: 1.24.1
-  build-tags: [safe]
+  build-tags:
+    - safe
   modules-download-mode: readonly
-
-issues:
-  exclude-dirs:
-    - 'tmp'
-  exclude-rules:
-    - path: _test\.go
-      linters:
-        - forbidigo
-        - forcetypeassert
-
-linters-settings:
-  misspell:
-    mode: restricted
-  asasalint:
-    ignore-test: true
-  # https://golangci-lint.run/usage/linters/#exhaustive
-  exhaustive:
-    default-signifies-exhaustive: true
-  # https://golangci-lint.run/usage/linters/#predeclared
-  predeclared:
-    ignore: "new,error"
-  # https://golangci-lint.run/usage/linters/#gocritic
-  gocritic:
-    disabled-checks:
-      - ifElseChain
-      - singleCaseSwitch
-      - commentFormatting
-  # https://golangci-lint.run/usage/linters/#testifylint
-  testifylint:
-    disable:
-      - float-compare
-  # https://golangci-lint.run/usage/linters/#gosec
-  gosec:
-    confidence: medium
-  # https://golangci-lint.run/usage/linters/#importas
-  importas:
-    no-unaliased: true
-  # https://golangci-lint.run/usage/linters/#gomoddirectives
-  gomoddirectives:
-    replace-local: true
-    replace-allow-list:
-      - github.com/c-bata/go-prompt
-  # https://golangci-lint.run/usage/linters/#staticcheck
-  staticcheck:
-    checks: ["all", "-SA1029"]
-  # https://golangci-lint.run/usage/linters/#revive
-  revive:
-    ignore-generated-header: true
-    enable-all-rules: true
-    rules:
-      - name: line-length-limit
-        disabled: true
-      - name: cognitive-complexity
-        disabled: true
-      - name: unused-parameter
-        disabled: true
-      - name: add-constant
-        disabled: true
-      - name: cyclomatic
-        disabled: true
-      - name: function-length
-        disabled: true
-      - name: function-result-limit
-        disabled: true
-      - name: flag-parameter
-        disabled: true
-      - name: unused-receiver
-        disabled: true
-      - name: argument-limit
-        disabled: true
-      - name: max-control-nesting
-        disabled: true
-      - name: comment-spacings
-        disabled: true
-      - name: struct-tag
-        arguments:
-          - "json,inline"
-      - name: unhandled-error
-        arguments:
-          - "fmt.Println"
-      # TODO remove
-      - name: use-any
-        disabled: true
-      - name: if-return
-        disabled: true
-      - name: deep-exit
-        disabled: true
-      - name: empty-block
-        disabled: true
-      - name: context-keys-type
-        disabled: true
-      - name: nested-structs
-        disabled: true
-      - name: unnecessary-stmt
-        disabled: true
-      - name: max-public-structs
-        disabled: true
-      - name: import-shadowing
-        disabled: true
-      - name: confusing-naming
-        disabled: true
-      - name: increment-decrement
-        disabled: true
-      - name: indent-error-flow
-        disabled: true
-      - name: unchecked-type-assertion
-        disabled: true
-
 linters:
-  disable-all: true
+  default: none
   enable:
     ## Default linters
     - errcheck # errcheck is a program for checking for unchecked errors in Go code. These unchecked errors can be critical bugs in some cases [fast: false, auto-fix: false]
-    - gosimple # (megacheck) Linter for Go source code that specializes in simplifying code [fast: false, auto-fix: false]
     - govet # (vet, vetshadow) Vet examines Go source code and reports suspicious constructs. It is roughly the same as 'go vet' and uses its passes. [fast: false, auto-fix: false]
     - ineffassign # Detects when assignments to existing variables are not used [fast: true, auto-fix: false]
     - staticcheck # (megacheck) It's a set of rules from staticcheck. It's not the same thing as the staticcheck binary. The author of staticcheck doesn't support or approve the use of staticcheck as a library inside golangci-lint. [fast: false, auto-fix: false]
@@ -129,7 +19,7 @@ linters:
     - asciicheck # checks that all code identifiers does not have non-ASCII symbols in the name [fast: true, auto-fix: false]
     - bidichk # Checks for dangerous unicode character sequences [fast: true, auto-fix: false]
     - bodyclose # checks whether HTTP response body is closed successfully [fast: false, auto-fix: false]
-    - canonicalheader # canonicalheader checks whether net/http.Header uses canonical header [fast: false, auto-fix: false]
+    - canonicalheader # checks whether net/http.Header uses canonical header [fast: false, auto-fix: false]
     #- containedctx # containedctx is a linter that detects struct contained context.Context field [fast: false, auto-fix: false]
     - contextcheck # check whether the function uses a non-inherited context [fast: false, auto-fix: false]
     #- copyloopvar # (go >= 1.22) copyloopvar is a linter detects places where loop variables are copied [fast: true, auto-fix: false]
@@ -147,9 +37,7 @@ linters:
     - gochecksumtype # Run exhaustiveness checks on Go "sum types" [fast: false, auto-fix: false]
     - goconst # Finds repeated strings that could be replaced by a constant [fast: true, auto-fix: false]
     - gocritic # Provides diagnostics that check for bugs, performance and style issues. [fast: false, auto-fix: true]
-    - gofmt # Gofmt checks whether code was gofmt-ed. By default this tool runs with -s option to check for code simplification [fast: true, auto-fix: true]
     - goheader # Checks is file header matches to pattern [fast: true, auto-fix: true]
-    - goimports # Check import statements are formatted according to the 'goimport' command. Reformat imports in autofix mode. [fast: true, auto-fix: true]
     - gomoddirectives # Manage the use of 'replace', 'retract', and 'excludes' directives in go.mod. [fast: true, auto-fix: false]
     - gomodguard # Allow and block list linter for direct Go module dependencies. This is different from depguard where there are different block types for example version constraints and module recommendations. [fast: true, auto-fix: false]
     - goprintffuncname # Checks that printf-like functions are named with `f` at the end. [fast: true, auto-fix: false]
@@ -181,7 +69,6 @@ linters:
     - rowserrcheck # checks whether Rows.Err of rows is checked successfully [fast: false, auto-fix: false]
     - spancheck # Checks for mistakes with OpenTelemetry/Census spans. [fast: false, auto-fix: false]
     - sqlclosecheck # Checks that sql.Rows, sql.Stmt, sqlx.NamedStmt, pgx.Query are closed. [fast: false, auto-fix: false]
-    - stylecheck # Stylecheck is a replacement for golint [fast: false, auto-fix: false]
     - testableexamples # linter checks if examples are testable (have an expected output) [fast: true, auto-fix: false]
     - testifylint # Checks usage of github.com/stretchr/testify. [fast: false, auto-fix: false]
     - testpackage # linter that makes you use a separate _test package [fast: true, auto-fix: false]
@@ -199,10 +86,10 @@ linters:
     #- dogsled # Checks assignments with too many blank identifiers (e.g. x, _, _, _, := f()) [fast: true, auto-fix: false]
     #- dupl # Tool for code clone detection [fast: true, auto-fix: false]
     #- dupword # checks for duplicate words in the source code [fast: true, auto-fix: false]
+    #- dogsled # Checks assignments with too many blank identifiers (e.g. x, _, _, _, := f()) [fast: true, auto-fix: false]
     #- err113 # Go linter to check the errors handling expressions [fast: false, auto-fix: false]
     #- exhaustruct # Checks if all structure fields are initialized [fast: false, auto-fix: false]
     #- funlen # Tool for detection of long functions [fast: true, auto-fix: false]
-    #- gci # Gci controls Go package import order and makes it always deterministic. [fast: true, auto-fix: true]
     #- ginkgolinter # enforces standards of using ginkgo and gomega [fast: false, auto-fix: false]
     #- gochecknoglobals # Check that no global variables exist. [fast: false, auto-fix: false]
     #- gochecknoinits # Checks that no init functions are present in Go code [fast: true, auto-fix: false]
@@ -210,7 +97,6 @@ linters:
     #- gocyclo # Computes and checks the cyclomatic complexity of functions [fast: true, auto-fix: false]
     #- godot # Check if comments end in a period [fast: true, auto-fix: true]
     #- godox # Tool for detection of comment keywords [fast: true, auto-fix: false]
-    #- gofumpt # Gofumpt checks whether code was gofumpt-ed. [fast: true, auto-fix: true]
     #- interfacebloat # A linter that checks the number of methods inside an interface. [fast: true, auto-fix: false]
     #- intrange # (go >= 1.22) intrange is a linter to find places where for loops could make use of an integer range. [fast: true, auto-fix: false]
     #- ireturn # Accept Interfaces, Return Concrete Types [fast: false, auto-fix: false]
@@ -230,3 +116,122 @@ linters:
     #- wrapcheck # Checks that errors returned from external packages are wrapped [fast: false, auto-fix: false]
     #- wsl # add or remove empty lines [fast: true, auto-fix: false]
     #- zerologlint # Detects the wrong usage of `zerolog` that a user forgets to dispatch with `Send` or `Msg` [fast: false, auto-fix: false]
+  settings:
+    exhaustive:
+      default-signifies-exhaustive: true
+    gocritic:
+      disabled-checks:
+        - ifElseChain
+        - singleCaseSwitch
+        - commentFormatting
+    gomoddirectives:
+      replace-allow-list:
+        - github.com/c-bata/go-prompt
+      replace-local: true
+    gosec:
+      confidence: medium
+    importas:
+      no-unaliased: true
+    misspell:
+      mode: restricted
+    predeclared:
+      ignore:
+        - new
+        - error
+    revive:
+      enable-all-rules: true
+      rules:
+        - name: line-length-limit
+          disabled: true
+        - name: cognitive-complexity
+          disabled: true
+        - name: unused-parameter
+          disabled: true
+        - name: add-constant
+          disabled: true
+        - name: cyclomatic
+          disabled: true
+        - name: function-length
+          disabled: true
+        - name: function-result-limit
+          disabled: true
+        - name: flag-parameter
+          disabled: true
+        - name: unused-receiver
+          disabled: true
+        - name: argument-limit
+          disabled: true
+        - name: max-control-nesting
+          disabled: true
+        - name: comment-spacings
+          disabled: true
+        - name: struct-tag
+          arguments:
+            - json,inline
+        - name: unhandled-error
+          arguments:
+            - fmt.Println
+        - name: use-any
+          disabled: true
+        - name: if-return
+          disabled: true
+        - name: deep-exit
+          disabled: true
+        - name: empty-block
+          disabled: true
+        - name: context-keys-type
+          disabled: true
+        - name: nested-structs
+          disabled: true
+        - name: unnecessary-stmt
+          disabled: true
+        - name: max-public-structs
+          disabled: true
+        - name: import-shadowing
+          disabled: true
+        - name: confusing-naming
+          disabled: true
+        - name: increment-decrement
+          disabled: true
+        - name: indent-error-flow
+          disabled: true
+        - name: unchecked-type-assertion
+          disabled: true
+    staticcheck:
+      checks:
+        - -SA1029
+        - all
+    testifylint:
+      disable:
+        - float-compare
+  exclusions:
+    generated: lax
+    presets:
+      - comments
+      - common-false-positives
+      - legacy
+      - std-error-handling
+    rules:
+      - linters:
+          - forbidigo
+          - forcetypeassert
+        path: _test\.go
+      - linters:
+          - asasalint
+        path: (.+)_test\.go
+    paths:
+      - tmp
+      - third_party$
+      - builtin$
+      - examples$
+formatters:
+  enable:
+    - gofmt
+    - goimports
+  exclusions:
+    generated: lax
+    paths:
+      - tmp
+      - third_party$
+      - builtin$
+      - examples$

pkg/cache/memorycache.go

@@ -17,7 +17,7 @@ func NewMemoryCache() *MemoryCache {
 func (c *MemoryCache) Clear(namespaces ...string) {
 	if len(namespaces) == 0 {
 		c.store.Range(func(key, value interface{}) bool {
-			namespaces = append(namespaces, key.(string))
+			namespaces = append(namespaces, key.(string)) //nolint:forcetypeassert
 			return true
 		})
 	}
@@ -30,13 +30,13 @@ func (c *MemoryCache) Get(namespace string) Namespace {
 	value, _ := c.store.LoadOrStore(namespace, &MemoryNamespace{
 		store: sync.Map{},
 	})
-	return value.(*MemoryNamespace)
+	return value.(*MemoryNamespace) //nolint:forcetypeassert
 }
 
 func (c *MemoryCache) List() map[string]Namespace {
 	ret := map[string]Namespace{}
 	c.store.Range(func(k, v interface{}) bool {
-		ret[k.(string)] = v.(*MemoryNamespace)
+		ret[k.(string)] = v.(*MemoryNamespace) //nolint:forcetypeassert
 		return true
 	})
 	return ret

pkg/cache/memorynamespace.go

@@ -32,7 +32,7 @@ func (c *MemoryNamespace) Get(key string, cb func() any) any {
 func (c *MemoryNamespace) Keys() []string {
 	var keys []string
 	c.store.Range(func(k, v interface{}) bool {
-		keys = append(keys, k.(string))
+		keys = append(keys, k.(string)) //nolint:forcetypeassert
 		return true
 	})
 	return keys

pkg/command/tree/root_test.go

@@ -426,5 +426,5 @@ func T(ctx context.Context) *testing.T {
 
 func SetT(ctx context.Context, t *testing.T) context.Context {
 	t.Helper()
-	return context.WithValue(ctx, "t", t)
+	return context.WithValue(ctx, "t", t) //nolint:staticcheck
 }

pkg/readline/flagset.go

@@ -29,7 +29,7 @@ func (s *FlagSet) SetValues(name string, values ...string) error {
 }
 
 func (s *FlagSet) GetValues(name string) []string {
-	if f := s.FlagSet.Lookup(name); f == nil {
+	if f := s.Lookup(name); f == nil {
 		return nil
 	} else if v, ok := f.Annotations["values"]; ok {
 		return v