foomo/sesamy-cli
1
0
Fork 0
mirror of https://github.com/foomo/sesamy-cli.git synced 2025-10-16 12:35:36 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #124 from foomo/feature/conversion-linker-accept-params

Browse Source 
feat(conversionlinker): add accept params
This commit is contained in:
Kevin Franklin Kim 2025-05-27 10:58:49 +02:00 committed by GitHub
commit c6f5292df3
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
6 changed files with 15 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
README.md
View File

@ -280,6 +280,8 @@ conversionLinker:
enabled: true
# Consent mode name
mode: ad_storage
# Accept incoming linker parameters
enableLinkerParams: true
# --- Umami settings
umami:

2
pkg/config/conversionlinker.go
View File

@ -5,4 +5,6 @@ type ConversionLinker struct {
Enabled bool `json:"enabled" yaml:"enabled"`
// Google Consent settings
GoogleConsent GoogleConsent `json:"googleConsent" yaml:"googleConsent"`
// Accept incoming linker parameters
EnableLinkerParams bool `json:"enableLinkerParams" yaml:"enableLinkerParams"`
}

2
pkg/provider/conversionlinker/server.go
View File

@ -35,7 +35,7 @@ func Server(ctx context.Context, tm *tagmanager.TagManager, cfg config.Conversio
return errors.Wrap(err, "failed to upsert event trigger: "+NameConversionLinkerTrigger)
}
if _, err := tm.UpsertTag(ctx, folder, containertag.NewConversionLinker(Name, eventTrigger)); err != nil {
if _, err := tm.UpsertTag(ctx, folder, containertag.NewConversionLinker(Name, cfg.EnableLinkerParams, eventTrigger)); err != nil {
return err
}

6
pkg/provider/conversionlinker/server/tag/conversionlinker.go
View File

@ -1,11 +1,13 @@
package tag
import (
"strconv"
"github.com/foomo/sesamy-cli/pkg/utils"
"google.golang.org/api/tagmanager/v2"
)
func NewConversionLinker(name string, triggers ...*tagmanager.Trigger) *tagmanager.Tag {
func NewConversionLinker(name string, enableLinkerParams bool, triggers ...*tagmanager.Trigger) *tagmanager.Tag {
return &tagmanager.Tag{
FiringTriggerId: utils.TriggerIDs(triggers),
Name: name,
@ -14,7 +16,7 @@ func NewConversionLinker(name string, triggers ...*tagmanager.Trigger) *tagmanag
{
Key: "enableLinkerParams",
Type: "boolean",
Value: "false",
Value: strconv.FormatBool(enableLinkerParams),
},
{
Key: "enableCookieOverrides",

4
sesamy.schema.json
View File

@ -141,6 +141,10 @@
"googleConsent": {
"$ref": "#/$defs/github.com.foomo.sesamy-cli.pkg.config.GoogleConsent",
"description": "Google Consent settings"
},
"enableLinkerParams": {
"type": "boolean",
"description": "Accept incoming linker parameters"
}
},
"additionalProperties": false,

2
sesamy.yaml
View File

@ -225,6 +225,8 @@ conversionLinker:
enabled: true
# Consent mode name
mode: ad_storage
# Accept incoming linker parameters
enableLinkerParams: true
# --- Umami settings
umami: