foomo/sesamy-go
1
0
Fork 0
mirror of https://github.com/foomo/sesamy-go.git synced 2025-10-16 12:35:43 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix: don't error on missing cookie

Browse Source
This commit is contained in:
Kevin Franklin Kim 2024-11-16 22:34:40 +01:00
parent e8e7722960
commit c975593c5c
No known key found for this signature in database
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
integration/watermill/mpv2/subscribermiddleware.go
View File

@ -19,7 +19,7 @@ func SubscriberMiddlewareSessionID(measurementID string) SubscriberMiddleware {
if payload.SessionID == "" { if payload.SessionID == "" {
value, err := session.ParseGASessionID(r, measurementID) value, err := session.ParseGASessionID(r, measurementID)
if err != nil && !errors.Is(err, http.ErrNoCookie) { if err != nil && !errors.Is(err, http.ErrNoCookie) {
return errors.Wrap(err, "failed to parse client cookie") return err
} }
payload.SessionID = value payload.SessionID = value
} }
@ -32,7 +32,7 @@ func SubscriberMiddlewareClientID(next SubscriberHandler) SubscriberHandler {
return func(l *zap.Logger, r *http.Request, payload *mpv2.Payload[any]) error { return func(l *zap.Logger, r *http.Request, payload *mpv2.Payload[any]) error {
if payload.ClientID == "" { if payload.ClientID == "" {
value, err := session.ParseGAClientID(r) value, err := session.ParseGAClientID(r)
if err != nil { if err != nil && !errors.Is(err, http.ErrNoCookie) {
return err return err
} }
payload.ClientID = value payload.ClientID = value
@ -43,8 +43,8 @@ func SubscriberMiddlewareClientID(next SubscriberHandler) SubscriberHandler {
func SubscriberMiddlewareDebugMode(next SubscriberHandler) SubscriberHandler { func SubscriberMiddlewareDebugMode(next SubscriberHandler) SubscriberHandler {
return func(l *zap.Logger, r *http.Request, payload *mpv2.Payload[any]) error { return func(l *zap.Logger, r *http.Request, payload *mpv2.Payload[any]) error {
if !payload.DebugMode { if !payload.DebugMode && session.IsGTMDebug(r) {
payload.DebugMode = session.IsGTMDebug(r) payload.DebugMode = true
} }
return next(l, r, payload) return next(l, r, payload)
} }