foomo/shop
1
0
Fork 0
mirror of https://github.com/foomo/shop.git synced 2025-10-16 12:35:39 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Remove spew dependency

Browse Source
This commit is contained in:
Stefan Martinov 2017-11-08 14:00:19 +01:00
parent 97afc4d1a2
commit 944c0e7039
4 changed files with 26 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Makefile
View File

@ -14,4 +14,3 @@ install-test-dependencies:
go get -u github.com/bwmarrin/snowflake
go get -u github.com/sergi/go-diff/...
go get -u github.com/nbutton23/zxcvbn-go
go get -u github.com/davecgh/go-spew

2
pricerule/calculator.go
View File

@ -204,7 +204,7 @@ func ApplyDiscounts(articleCollection *ArticleCollection, existingDiscounts Orde
bestOptionCustomerProductRulePerItem := getBestOptionCustomerProductRulePerItem(ruleVoucherPairs, calculationParameters)
calculationParameters.bestOptionCustomeProductRulePerItem = bestOptionCustomerProductRulePerItem
//spew.Dump(bestOptionCustomerProductRulePerItem)
//utils.PrintJSON(bestOptionCustomerProductRulePerItem)
for _, priceRulePair := range ruleVoucherPairs {
pair := RuleVoucherPair{}

50
pricerule/pricerule_test.go
View File

@ -7,7 +7,7 @@ import (
"testing"
"time"
"github.com/davecgh/go-spew/spew"
"github.com/foomo/shop/utils"
)
const (
@ -169,7 +169,7 @@ func testGetApplicableVouchers(t *testing.T) {
// PRICERULES --------------------------------------------------------------------------------------
applicableRules, err := PickApplicableVouchers([]string{VoucherCode1, VoucherCode2}, orderVo, []string{}, nil)
spew.Dump(applicableRules)
utils.PrintJSON(applicableRules)
}
@ -311,7 +311,7 @@ func testShipping1(t *testing.T) {
orderVo.Articles = append(orderVo.Articles, positionVo)
discountsVo, summary, err := ApplyDiscounts(orderVo, nil, []string{""}, []string{}, 0.05, nil)
spew.Dump(discountsVo, summary, err)
utils.PrintJSON(discountsVo, summary, err)
}
@ -397,7 +397,7 @@ func testBlacklist(t *testing.T) {
orderVo.Articles = append(orderVo.Articles, positionVo)
discountsVo, summary, err := ApplyDiscounts(orderVo, nil, []string{}, []string{PaymentMethodID1}, 0.05, nil)
spew.Dump(discountsVo, summary, err)
utils.PrintJSON(discountsVo, summary, err)
}
@ -518,7 +518,7 @@ func testDiscountDistribution(t *testing.T) {
orderVo.Articles = append(orderVo.Articles, positionVo)
discountsVo, summary, err := ApplyDiscounts(orderVo, nil, []string{"vouchercode"}, []string{}, 0.05, nil)
spew.Dump(discountsVo, summary, err)
utils.PrintJSON(discountsVo, summary, err)
}
@ -647,7 +647,7 @@ func testBestOption(t *testing.T) {
orderVo.Articles = append(orderVo.Articles, positionVo)
discountsVo, summary, err := ApplyDiscounts(orderVo, nil, []string{}, []string{}, 0.05, nil)
spew.Dump(discountsVo, summary, err)
utils.PrintJSON(discountsVo, summary, err)
}
@ -719,7 +719,7 @@ func testDiscountFoItemSets(t *testing.T) {
orderVo.Articles = append(orderVo.Articles, positionVo)
discountsVo, summary, err := ApplyDiscounts(orderVo, nil, []string{}, []string{PaymentMethodID1}, 0.05, nil)
spew.Dump(discountsVo, summary, err)
utils.PrintJSON(discountsVo, summary, err)
}
@ -790,7 +790,7 @@ func testVoucherRuleWithCheckoutAttributes(t *testing.T) {
orderVo.Articles = append(orderVo.Articles, positionVo)
discountsVo, summary, err := ApplyDiscounts(orderVo, nil, []string{}, []string{PaymentMethodID1}, 0.05, nil)
spew.Dump(discountsVo, summary, err)
utils.PrintJSON(discountsVo, summary, err)
}
@ -863,7 +863,7 @@ func testShipping(t *testing.T) {
orderVo.Articles = append(orderVo.Articles, positionVo)
discountsVo, summary, err := ApplyDiscounts(orderVo, nil, []string{""}, []string{}, 0.05, nil)
spew.Dump(discountsVo, summary, err)
utils.PrintJSON(discountsVo, summary, err)
}
@ -875,7 +875,7 @@ func testCache(t *testing.T) {
RemoveAllVouchers()
//cache.InitCatalogCalculationCache()
//spew.Dump(cache.GetGroupsCache())
//utils.PrintJSON(cache.GetGroupsCache())
//cache.ClearCatalogCalculationCache()
for _, groupID := range []string{GroupIDSale, GroupIDNormal, GroupIDShirts} {
@ -920,7 +920,7 @@ func testCache(t *testing.T) {
}
cache.InitCatalogCalculationCache()
//spew.Dump(cache.GetGroupsCache())
//utils.PrintJSON(cache.GetGroupsCache())
//create articleCollection
orderVo, err := createMockOrderScaled(t)
@ -928,7 +928,7 @@ func testCache(t *testing.T) {
panic(err)
}
discountsVo, summary, err := ApplyDiscountsOnCatalog(orderVo, nil, 0.05, nil)
spew.Dump(discountsVo, summary, err)
utils.PrintJSON(discountsVo, summary, err)
}
// Test groups creation
@ -1002,8 +1002,8 @@ func testScaled(t *testing.T) {
panic(err)
}
fmt.Println("discounts for scaled percentage")
spew.Dump(discountsVo)
spew.Dump(*summary)
utils.PrintJSON(discountsVo)
utils.PrintJSON(*summary)
}
// Test groups creation
@ -1074,8 +1074,8 @@ func testBuyXGetY(t *testing.T) {
}
fmt.Println("discounts for buy x get y")
spew.Dump(discountsVo)
spew.Dump(*summary)
utils.PrintJSON(discountsVo)
utils.PrintJSON(*summary)
}
@ -1125,15 +1125,15 @@ func testExclude(t *testing.T) {
calculationParameters.productGroupIDsPerPosition = productGroupIDsPerPosition
calculationParameters.isCatalogCalculation = false
calculationParameters.articleCollection = orderVo
//spew.Dump(productGroupIDsPerPosition)
//utils.PrintJSON(productGroupIDsPerPosition)
for _, article := range orderVo.Articles {
ok, _ := validatePriceRuleForPosition(*priceRule, article, calculationParameters, nil)
log.Println(article.ID + " " + priceRule.ID + " " + strconv.FormatBool(ok))
}
discountsVo, summary, err := ApplyDiscounts(orderVo, nil, []string{}, []string{"blah"}, 0.05, nil)
spew.Dump(discountsVo)
spew.Dump(*summary)
utils.PrintJSON(discountsVo)
utils.PrintJSON(*summary)
}
@ -1225,8 +1225,8 @@ func testMaxOrder(t *testing.T) {
}
fmt.Println("discounts")
spew.Dump(discountsVo)
spew.Dump(*summary)
utils.PrintJSON(discountsVo)
utils.PrintJSON(*summary)
//validate the voucher
@ -1365,8 +1365,8 @@ func testTwoStepWorkflow(t *testing.T) {
}
fmt.Println("discounts")
spew.Dump(discountsVo)
spew.Dump(*summary)
utils.PrintJSON(discountsVo)
utils.PrintJSON(*summary)
}
@ -1388,8 +1388,8 @@ func testPricerulesWorkflow(t *testing.T) {
}
fmt.Println("discounts")
spew.Dump(discountsVo)
spew.Dump(*summary)
utils.PrintJSON(discountsVo)
utils.PrintJSON(*summary)
}

1
queue/queue.go
View File

@ -199,7 +199,6 @@ func runProcessor(processor Processor) error {
select {
case data := <-chanReady:
// fmt.Println("--- DATA")
// fmt.Println(spew.Sdump(data))
f := func(data interface{}) {
err := processor.Process(data)
if err != nil {