feat: bump golangci-lint

2025-10-16 12:45:37 +00:00 · 2025-05-21 14:49:51 +02:00 · 2025-05-21 14:49:51 +02:00 · 898ffa7146
commit 898ffa7146
parent 4a4d334336
3 changed files with 57 additions and 47 deletions
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@ -26,7 +26,7 @@ jobs:
        with:
          token: ${{ secrets.GITHUB_TOKEN }}

-      - uses: golangci/golangci-lint-action@v6
+      - uses: golangci/golangci-lint-action@v8
        with:
          version: latest
          args: --timeout=5m
--- a/.golangci.yml
+++ b/.golangci.yml
@ -1,49 +1,15 @@
-# yaml-language-server: $schema=https://golangci-lint.run/jsonschema/golangci.jsonschema.json
 # https://golangci-lint.run/usage/configuration/
-
+# yaml-language-server: $schema=https://golangci-lint.run/jsonschema/golangci.jsonschema.json
+version: "2"
 run:
  go: 1.24.1
-  build-tags: [safe]
+  build-tags: [ safe ]
  modules-download-mode: readonly
-
-linters-settings:
-  importas:
-    alias:
-      - pkg: '^github.com\/foomo\/typesense\/(.*\/)?([^\/]+)\/?$'
-        alias: '${2}x' # enforce `x` suffix
-    no-unaliased: true
-  # https://golangci-lint.run/usage/linters/#revive
-  revive:
-    ignore-generated-header: true
-    enable-all-rules: true
-    rules:
-      - name: unused-parameter
-        disabled: true
-      - name: line-length-limit
-        disabled: true
-      - name: add-constant
-        disabled: true
-      - name: function-result-limit
-        disabled: true
-      - name: cognitive-complexity
-        disabled: true
-      - name: unused-receiver
-        disabled: true
-      - name: use-any
-        disabled: true
-      - name: cyclomatic
-        disabled: true
-      - name:  function-length
-        disabled: true
-      - name:  max-public-structs
-        disabled: true
-
 linters:
-  disable-all: true
+  default: none
  enable:
    ## Default linters
    - errcheck # errcheck is a program for checking for unchecked errors in Go code. These unchecked errors can be critical bugs in some cases [fast: false, auto-fix: false]
-    - gosimple # (megacheck) Linter for Go source code that specializes in simplifying code [fast: false, auto-fix: false]
    - govet # (vet, vetshadow) Vet examines Go source code and reports suspicious constructs. It is roughly the same as 'go vet' and uses its passes. [fast: false, auto-fix: false]
    - ineffassign # Detects when assignments to existing variables are not used [fast: true, auto-fix: false]
    - staticcheck # (megacheck) It's a set of rules from staticcheck. It's not the same thing as the staticcheck binary. The author of staticcheck doesn't support or approve the use of staticcheck as a library inside golangci-lint. [fast: false, auto-fix: false]
@ -72,9 +38,7 @@ linters:
    - gochecksumtype # Run exhaustiveness checks on Go "sum types" [fast: false, auto-fix: false]
    - goconst # Finds repeated strings that could be replaced by a constant [fast: true, auto-fix: false]
    - gocritic # Provides diagnostics that check for bugs, performance and style issues. [fast: false, auto-fix: true]
-    - gofmt # Gofmt checks whether code was gofmt-ed. By default this tool runs with -s option to check for code simplification [fast: true, auto-fix: true]
    - goheader # Checks is file header matches to pattern [fast: true, auto-fix: true]
-    - goimports # Check import statements are formatted according to the 'goimport' command. Reformat imports in autofix mode. [fast: true, auto-fix: true]
    - gomoddirectives # Manage the use of 'replace', 'retract', and 'excludes' directives in go.mod. [fast: true, auto-fix: false]
    - gomodguard # Allow and block list linter for direct Go module dependencies. This is different from depguard where there are different block types for example version constraints and module recommendations. [fast: true, auto-fix: false]
    - goprintffuncname # Checks that printf-like functions are named with `f` at the end. [fast: true, auto-fix: false]
@ -84,7 +48,6 @@ linters:
    - iface # Detect the incorrect use of interfaces, helping developers avoid interface pollution. [fast: false, auto-fix: false]
    - importas # Enforces consistent import aliases [fast: false, auto-fix: false]
    - inamedparam # reports interfaces with unnamed method parameters [fast: true, auto-fix: false]
-    - intrange # (go >= 1.22) intrange is a linter to find places where for loops could make use of an integer range. [fast: true, auto-fix: false]
    - loggercheck # (logrlint) Checks key value pairs for common logger libraries (kitlog,klog,logr,zap). [fast: false, auto-fix: false]
    - makezero # Finds slice declarations with non-zero initial length [fast: false, auto-fix: false]
    - mirror # reports wrong mirror patterns of bytes/strings usage [fast: false, auto-fix: true]
@ -107,7 +70,6 @@ linters:
    - rowserrcheck # checks whether Rows.Err of rows is checked successfully [fast: false, auto-fix: false]
    - spancheck # Checks for mistakes with OpenTelemetry/Census spans. [fast: false, auto-fix: false]
    - sqlclosecheck # Checks that sql.Rows, sql.Stmt, sqlx.NamedStmt, pgx.Query are closed. [fast: false, auto-fix: false]
-    - stylecheck # Stylecheck is a replacement for golint [fast: false, auto-fix: false]
    - testableexamples # linter checks if examples are testable (have an expected output) [fast: true, auto-fix: false]
    - testifylint # Checks usage of github.com/stretchr/testify. [fast: false, auto-fix: false]
    - testpackage # linter that makes you use a separate _test package [fast: true, auto-fix: false]
@ -129,7 +91,6 @@ linters:
    #- err113 # Go linter to check the errors handling expressions [fast: false, auto-fix: false]
    #- exhaustruct # Checks if all structure fields are initialized [fast: false, auto-fix: false]
    #- funlen # Tool for detection of long functions [fast: true, auto-fix: false]
-    #- gci # Gci controls Go package import order and makes it always deterministic. [fast: true, auto-fix: true]
    #- ginkgolinter # enforces standards of using ginkgo and gomega [fast: false, auto-fix: false]
    #- gochecknoglobals # Check that no global variables exist. [fast: false, auto-fix: false]
    #- gochecknoinits # Checks that no init functions are present in Go code [fast: true, auto-fix: false]
@ -137,7 +98,6 @@ linters:
    #- gocyclo # Computes and checks the cyclomatic complexity of functions [fast: true, auto-fix: false]
    #- godot # Check if comments end in a period [fast: true, auto-fix: true]
    #- godox # Tool for detection of comment keywords [fast: true, auto-fix: false]
-    #- gofumpt # Gofumpt checks whether code was gofumpt-ed. [fast: true, auto-fix: true]
    #- interfacebloat # A linter that checks the number of methods inside an interface. [fast: true, auto-fix: false]
    #- intrange # (go >= 1.22) intrange is a linter to find places where for loops could make use of an integer range. [fast: true, auto-fix: false]
    #- ireturn # Accept Interfaces, Return Concrete Types [fast: false, auto-fix: false]
@ -157,3 +117,53 @@ linters:
    #- wrapcheck # Checks that errors returned from external packages are wrapped [fast: false, auto-fix: false]
    #- wsl # add or remove empty lines [fast: true, auto-fix: false]
    #- zerologlint # Detects the wrong usage of `zerolog` that a user forgets to dispatch with `Send` or `Msg` [fast: false, auto-fix: false]
+  settings:
+    importas:
+      alias:
+        - pkg: ^github.com\/foomo\/typesense\/(.*\/)?([^\/]+)\/?$
+          alias: ${2}x
+      no-unaliased: true
+    revive:
+      enable-all-rules: true
+      rules:
+        - name: unused-parameter
+          disabled: true
+        - name: line-length-limit
+          disabled: true
+        - name: add-constant
+          disabled: true
+        - name: function-result-limit
+          disabled: true
+        - name: cognitive-complexity
+          disabled: true
+        - name: unused-receiver
+          disabled: true
+        - name: use-any
+          disabled: true
+        - name: cyclomatic
+          disabled: true
+        - name: function-length
+          disabled: true
+        - name: max-public-structs
+          disabled: true
+  exclusions:
+    generated: lax
+    presets:
+      - comments
+      - common-false-positives
+      - legacy
+      - std-error-handling
+    paths:
+      - third_party$
+      - builtin$
+      - examples$
+formatters:
+  enable:
+    - gofmt
+    - goimports
+  exclusions:
+    generated: lax
+    paths:
+      - third_party$
+      - builtin$
+      - examples$
--- a/.husky.yaml
+++ b/.husky.yaml
@ -1,6 +1,6 @@
 hooks:
  pre-commit:
-    - golangci-lint run --fast
+    - golangci-lint run --fast-only
    - husky lint-staged
  commit-msg:
    # only execute if not in a merge
@ -8,7 +8,7 @@

 lint-staged:
  '*.go':
-    - goimports -l -w
+    - golangci-lint fmt

 lint-commit:
  types: '^(feat|fix|build|chore|docs|perf|refactor|revert|style|test|wip)$'