From df83fbddb61b46d020306e523408ccd57ddd2fbb Mon Sep 17 00:00:00 2001 From: Wlad Meixner Date: Mon, 7 Sep 2026 11:50:34 +0200 Subject: [PATCH] fix(base-ui): keep menu labels inside a Menu.Group Menu.GroupLabel requires a Menu.Group ancestor, which radix's DropdownMenu.Label did not. Four labels were orphaned and threw "MenuGroupContext is missing" as soon as those menus opened. "Workspaces" moves into the group it labels; the standalone headings ("My account", "lena@foomo.org", "Toggle columns") each get their own group so the visual order is unchanged. The first QA pass missed this because it opened only the Notifications menu, which has no label. Replaced with a sweep over every overlay trigger in every story and tab panel at two viewports: 203 layers, 0 errors. --- src/components/data-table.tsx | 4 +++- src/stories/Dashboard.stories.tsx | 10 +++++++--- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/src/components/data-table.tsx b/src/components/data-table.tsx index c4e6eb4..fe4937f 100644 --- a/src/components/data-table.tsx +++ b/src/components/data-table.tsx @@ -385,7 +385,9 @@ function DataTable< } /> - Toggle columns + + Toggle columns + {table diff --git a/src/stories/Dashboard.stories.tsx b/src/stories/Dashboard.stories.tsx index 504f81f..3adfd7c 100644 --- a/src/stories/Dashboard.stories.tsx +++ b/src/stories/Dashboard.stories.tsx @@ -487,8 +487,8 @@ function AppSidebar() { } /> - Workspaces + Workspaces Foomo Inc. @@ -642,7 +642,9 @@ function AppSidebar() { align="start" className="lib:w-56" > - My account + + My account + @@ -750,7 +752,9 @@ function DashboardHeader({ onOpenCommand }: { onOpenCommand: () => void }) { } /> - lena@foomo.org + + lena@foomo.org +