From 33ace784b8444eeb85e60cee92fd51a4eb601a74 Mon Sep 17 00:00:00 2001
From: Abhi Aiyer <abhiaiyer91@gmail.com>
Date: Wed, 5 Dec 2018 11:36:54 -0800
Subject: [PATCH 1/2] fix typings for chatter and metadata for finally

---
 types/jsforce/api/chatter.d.ts  | 2 ++
 types/jsforce/api/metadata.d.ts | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/types/jsforce/api/chatter.d.ts b/types/jsforce/api/chatter.d.ts
index 4e0982ca24..5c300a7b4e 100644
--- a/types/jsforce/api/chatter.d.ts
+++ b/types/jsforce/api/chatter.d.ts
@@ -41,6 +41,8 @@ export class Request<T> implements Promise<T> {
     then<TResult1, TResult2>(onfulfilled?: ((value: T) => (PromiseLike<TResult1> | TResult1)) | null | undefined,
                              onrejected?: ((reason: any) => (PromiseLike<TResult2> | TResult2)) | null | undefined): Promise<TResult1 | TResult2>;
 
+    finally(onfinally?: () => void): Promise<T>
+    
     thenCall(callback?: (err: Error, records: T) => void): Query<T>;
 
     readonly [Symbol.toStringTag]: 'Promise';
diff --git a/types/jsforce/api/metadata.d.ts b/types/jsforce/api/metadata.d.ts
index 15f0fe249e..ce7476a731 100644
--- a/types/jsforce/api/metadata.d.ts
+++ b/types/jsforce/api/metadata.d.ts
@@ -124,6 +124,8 @@ export class AsyncResultLocator<T> extends EventEmitter implements Promise<T> {
     then<TResult1, TResult2>(onfulfilled?: ((value: T) => (PromiseLike<TResult1> | TResult1)) | null | undefined,
                              onrejected?: ((reason: any) => (PromiseLike<TResult2> | TResult2)) | null | undefined): Promise<TResult1 | TResult2>;
 
+    finally(onfinally?: () => void): Promise<T>
+    
     readonly [Symbol.toStringTag]: "Promise";
 }
 

From b81e520dc29fb85d68891b348d26556374d3e35c Mon Sep 17 00:00:00 2001
From: Abhi Aiyer <abhiaiyer91@gmail.com>
Date: Wed, 5 Dec 2018 12:11:31 -0800
Subject: [PATCH 2/2] fix typings for chatter and metadata for finally

---
 types/jsforce/api/chatter.d.ts  | 4 ++--
 types/jsforce/api/metadata.d.ts | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/types/jsforce/api/chatter.d.ts b/types/jsforce/api/chatter.d.ts
index 5c300a7b4e..c712187559 100644
--- a/types/jsforce/api/chatter.d.ts
+++ b/types/jsforce/api/chatter.d.ts
@@ -41,8 +41,8 @@ export class Request<T> implements Promise<T> {
     then<TResult1, TResult2>(onfulfilled?: ((value: T) => (PromiseLike<TResult1> | TResult1)) | null | undefined,
                              onrejected?: ((reason: any) => (PromiseLike<TResult2> | TResult2)) | null | undefined): Promise<TResult1 | TResult2>;
 
-    finally(onfinally?: () => void): Promise<T>
-    
+    finally(onfinally?: () => void): Promise<T>;
+
     thenCall(callback?: (err: Error, records: T) => void): Query<T>;
 
     readonly [Symbol.toStringTag]: 'Promise';
diff --git a/types/jsforce/api/metadata.d.ts b/types/jsforce/api/metadata.d.ts
index ce7476a731..c6aec12e7e 100644
--- a/types/jsforce/api/metadata.d.ts
+++ b/types/jsforce/api/metadata.d.ts
@@ -124,8 +124,8 @@ export class AsyncResultLocator<T> extends EventEmitter implements Promise<T> {
     then<TResult1, TResult2>(onfulfilled?: ((value: T) => (PromiseLike<TResult1> | TResult1)) | null | undefined,
                              onrejected?: ((reason: any) => (PromiseLike<TResult2> | TResult2)) | null | undefined): Promise<TResult1 | TResult2>;
 
-    finally(onfinally?: () => void): Promise<T>
-    
+    finally(onfinally?: () => void): Promise<T>;
+
     readonly [Symbol.toStringTag]: "Promise";
 }