From 49d71168496522ca3462fcc1207def917c83dec2 Mon Sep 17 00:00:00 2001 From: Chris Barr Date: Thu, 15 Dec 2016 12:19:22 -0500 Subject: [PATCH 1/3] Add typedefs for the semver-diff package: https://github.com/sindresorhus/semver-diff --- semver-diff/index.d.ts | 14 ++++++++++++++ semver-diff/semver-diff-tests.ts | 15 +++++++++++++++ semver-diff/tsconfig.json | 19 +++++++++++++++++++ semver-diff/tslint.json | 1 + 4 files changed, 49 insertions(+) create mode 100644 semver-diff/index.d.ts create mode 100644 semver-diff/semver-diff-tests.ts create mode 100644 semver-diff/tsconfig.json create mode 100644 semver-diff/tslint.json diff --git a/semver-diff/index.d.ts b/semver-diff/index.d.ts new file mode 100644 index 0000000000..f5db0845c0 --- /dev/null +++ b/semver-diff/index.d.ts @@ -0,0 +1,14 @@ +// Type definitions for semver-diff v2.1.0 +// Project: https://github.com/sindresorhus/semver-diff +// Definitions by: Chris Barr +// Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/semver-diff + +declare namespace SemverDiff { + type SemverDiffReturn = 'major' | 'minor' | 'patch' | 'prerelease' | 'build' | null; + + export default function(versionA: string, versionB: string): SemverDiffReturn; +} + +declare module 'semver-diff' { + export = SemverDiff.default; +} diff --git a/semver-diff/semver-diff-tests.ts b/semver-diff/semver-diff-tests.ts new file mode 100644 index 0000000000..fca7d8552e --- /dev/null +++ b/semver-diff/semver-diff-tests.ts @@ -0,0 +1,15 @@ +import semverDiff = require('semver-diff'); + +semverDiff('1.1.1', '1.1.2'); //=> 'patch' + +semverDiff('0.0.1', '1.0.0'); //=> 'major' + +semverDiff('0.0.1', '0.1.0'); //=> 'minor' + +semverDiff('0.0.1-foo', '0.0.1-foo.bar'); //=> 'prerelease' + +semverDiff('0.1.0', '0.1.0+foo'); //=> 'build' + +semverDiff('0.0.1', '0.0.1'); //=> null + +semverDiff('0.0.2', '0.0.1'); //=> null diff --git a/semver-diff/tsconfig.json b/semver-diff/tsconfig.json new file mode 100644 index 0000000000..33f2ad3018 --- /dev/null +++ b/semver-diff/tsconfig.json @@ -0,0 +1,19 @@ +{ + "compilerOptions": { + "module": "commonjs", + "target": "es6", + "noImplicitAny": true, + "strictNullChecks": true, + "baseUrl": "../", + "typeRoots": [ + "../" + ], + "types": [], + "noEmit": true, + "forceConsistentCasingInFileNames": true + }, + "files": [ + "index.d.ts", + "semver-diff-tests.ts" + ] +} \ No newline at end of file diff --git a/semver-diff/tslint.json b/semver-diff/tslint.json new file mode 100644 index 0000000000..377cc837d4 --- /dev/null +++ b/semver-diff/tslint.json @@ -0,0 +1 @@ +{ "extends": "../tslint.json" } From 4203d0aebdcfecdd789b23338c5005c89db23aa5 Mon Sep 17 00:00:00 2001 From: Chris Barr Date: Thu, 15 Dec 2016 12:55:17 -0500 Subject: [PATCH 2/3] Fix version number linting violation --- semver-diff/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/semver-diff/index.d.ts b/semver-diff/index.d.ts index f5db0845c0..7882013634 100644 --- a/semver-diff/index.d.ts +++ b/semver-diff/index.d.ts @@ -1,4 +1,4 @@ -// Type definitions for semver-diff v2.1.0 +// Type definitions for semver-diff 2.1 // Project: https://github.com/sindresorhus/semver-diff // Definitions by: Chris Barr // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/semver-diff From 7859d61c5a9250e054aeb690950f0bf50601a05b Mon Sep 17 00:00:00 2001 From: Chris Barr Date: Thu, 15 Dec 2016 14:56:18 -0500 Subject: [PATCH 3/3] Simplify based on suggestions --- semver-diff/index.d.ts | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/semver-diff/index.d.ts b/semver-diff/index.d.ts index 7882013634..550784e697 100644 --- a/semver-diff/index.d.ts +++ b/semver-diff/index.d.ts @@ -4,11 +4,9 @@ // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/semver-diff declare namespace SemverDiff { - type SemverDiffReturn = 'major' | 'minor' | 'patch' | 'prerelease' | 'build' | null; - - export default function(versionA: string, versionB: string): SemverDiffReturn; + type SemverDiffReturn = 'major' | 'minor' | 'patch' | 'prerelease' | 'build' | null; } -declare module 'semver-diff' { - export = SemverDiff.default; -} +declare function SemverDiff(versionA: string, versionB: string): SemverDiff.SemverDiffReturn; + +export = SemverDiff; \ No newline at end of file