From 01f150504678ce8efdc6bb296cd8712811c5ffd5 Mon Sep 17 00:00:00 2001 From: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com> Date: Fri, 24 May 2019 08:28:54 -0700 Subject: [PATCH] Fixes from express-service-static-core cleanup (#35704) CI missed some dependencies. Also update opossum's project url. --- types/express-handlebars/index.d.ts | 2 +- types/i18n/i18n-tests.ts | 6 ++---- types/opossum/index.d.ts | 2 +- types/passport/passport-tests.ts | 6 ++---- 4 files changed, 6 insertions(+), 10 deletions(-) diff --git a/types/express-handlebars/index.d.ts b/types/express-handlebars/index.d.ts index 50eb804939..2724c4fb55 100644 --- a/types/express-handlebars/index.d.ts +++ b/types/express-handlebars/index.d.ts @@ -45,7 +45,7 @@ interface Exphbs { } interface ExpressHandlebars { - (options?: ExphbsOptions): Function; + (options?: ExphbsOptions): (...args: any[]) => any; create (options?: ExphbsOptions): Exphbs; } diff --git a/types/i18n/i18n-tests.ts b/types/i18n/i18n-tests.ts index a24e4d4300..e5ba2b4bd9 100644 --- a/types/i18n/i18n-tests.ts +++ b/types/i18n/i18n-tests.ts @@ -105,10 +105,8 @@ const greeting = i18n.__('Hello'); * https://github.com/mashpie/i18n-node#example-usage-in-expressjs */ // Configuration -app.configure(() => { - // default: using 'accept-language' header to guess language settings - app.use(i18n.init); -}); +// default: using 'accept-language' header to guess language settings +app.use(i18n.init); app.get('/de', (_req: Express.Request, res: Express.Response) => { const greeting = res.__('Hello'); diff --git a/types/opossum/index.d.ts b/types/opossum/index.d.ts index 612615ad86..5ff0d04bf7 100644 --- a/types/opossum/index.d.ts +++ b/types/opossum/index.d.ts @@ -1,5 +1,5 @@ // Type definitions for opossum 1.10 -// Project: https://github.com/nodeshift/opossum +// Project: https://github.com/nodeshift/opossum, https://nodeshift.dev/opossum // Definitions by: Quinn Langille // Willy Zhang // Lance Ball diff --git a/types/passport/passport-tests.ts b/types/passport/passport-tests.ts index 2e7d003291..6f087c3bdf 100644 --- a/types/passport/passport-tests.ts +++ b/types/passport/passport-tests.ts @@ -67,10 +67,8 @@ passport.use(new TestStrategy()) .framework(newFramework); const app = express(); -app.configure(() => { - app.use(passport.initialize()); - app.use(passport.session()); -}); +app.use(passport.initialize()); +app.use(passport.session()); app.post('/login', passport.authenticate('local', { failureRedirect: '/login', failureFlash: true }),