From f32b52127dca1db30ad7def58a52534ca2dc9175 Mon Sep 17 00:00:00 2001 From: Steven Date: Sun, 2 Dec 2018 19:31:42 -0800 Subject: [PATCH 1/2] fix [SerialPort]: Change `data` -> `delimiter` in ready-parser options See [the implementation](https://github.com/node-serialport/node-serialport/blob/8825d264436e91ca727a0c9b4d04a756479c4b1f/packages/parser-ready/ready.js#L22-L24) of the ready parser --- types/serialport/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/serialport/index.d.ts b/types/serialport/index.d.ts index 14ded3b6e3..c1a81376fa 100644 --- a/types/serialport/index.d.ts +++ b/types/serialport/index.d.ts @@ -103,7 +103,7 @@ declare namespace SerialPort { constructor(options: {delimiter: string | Buffer | number[], encoding?: 'ascii'|'utf8'|'utf16le'|'ucs2'|'base64'|'binary'|'hex'}); } class Ready extends Stream.Transform { - constructor(options: {data: string | Buffer | number[]}); + constructor(options: {delimiter: string | Buffer | number[]}); } class Regex extends Stream.Transform { constructor(options: {regex: RegExp}); From b1eb8bdee501bf2e2022593f74f6028ce76932fc Mon Sep 17 00:00:00 2001 From: Steven Date: Sun, 2 Dec 2018 19:40:16 -0800 Subject: [PATCH 2/2] Update serialport-tests.ts --- types/serialport/serialport-tests.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/serialport/serialport-tests.ts b/types/serialport/serialport-tests.ts index 16cf2b6a70..d6541a63c2 100644 --- a/types/serialport/serialport-tests.ts +++ b/types/serialport/serialport-tests.ts @@ -107,7 +107,7 @@ function test_parsers() { const CCTalkParser = new SerialPort.parsers.CCTalk(); const DelimiterParser = new SerialPort.parsers.Delimiter({ delimiter: Buffer.from('EOL') }); const ReadlineParser = new SerialPort.parsers.Readline({ delimiter: '\r\n' }); - const ReadyParser = new SerialPort.parsers.Ready({ data: 'READY' }); + const ReadyParser = new SerialPort.parsers.Ready({ delimiter: 'READY' }); const RegexParser = new SerialPort.parsers.Regex({regex: /.*/}); port.pipe(ByteLengthParser);