From 04a5483d77c8407531505b4bd97d3a7d1ebfb01b Mon Sep 17 00:00:00 2001 From: Boris Breuer Date: Mon, 22 Jan 2018 22:45:04 +0100 Subject: [PATCH] Modified Jasmine (#23094) * According to the documentation, execute arguments are optional. See https://jasmine.github.io/2.3/node.html for more information. * Added name to package header. * The onComplete callback comes with a boolean indicating if the tests pased. Specify a custom onComplete callback. The callback is given a boolean of whether all of the specs passed or not. This is often used to message a status to task runners like grunt. See also https://jasmine.github.io/2.3/node.html. --- types/jasmine/index.d.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/types/jasmine/index.d.ts b/types/jasmine/index.d.ts index ed068f4775..dd482c925f 100644 --- a/types/jasmine/index.d.ts +++ b/types/jasmine/index.d.ts @@ -1,6 +1,6 @@ // Type definitions for Jasmine 2.8.0 // Project: http://jasmine.github.io/ -// Definitions by: Boris Yankov , Theodore Brown , David Pärsson , Gabe Moothart , Lukas Zech +// Definitions by: Boris Yankov , Theodore Brown , David Pärsson , Gabe Moothart , Lukas Zech , Boris Breuer // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped // TypeScript Version: 2.1 @@ -718,13 +718,13 @@ declare module "jasmine" { addSpecFile(filePath: string): void; addSpecFiles(files: string[]): void; configureDefaultReporter(options: any, ...args: any[]): void; - execute(files: any, filterString: any): any; + execute(files?: string[], filterString?: string): any; exitCodeCompletion(passed: any): void; loadConfig(config: any): void; loadConfigFile(configFilePath: any): void; loadHelpers(): void; loadSpecs(): void; - onComplete(onCompleteCallback: () => void): void; + onComplete(onCompleteCallback: (passed: boolean) => void): void; provideFallbackReporter(reporter: jasmine.Reporter): void; randomizeTests(value?: any): boolean; seed(value: any): void;