From 04b6461078f6696649acb7cdee8e6a57e2b1e2fa Mon Sep 17 00:00:00 2001 From: Andy Date: Wed, 27 Sep 2017 11:38:07 -0700 Subject: [PATCH] popper.js: Fix lint (#20084) --- types/popper.js/index.d.ts | 7 ++++++- types/popper.js/tslint.json | 6 ++---- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/types/popper.js/index.d.ts b/types/popper.js/index.d.ts index 2af9ae2298..19e892cc03 100644 --- a/types/popper.js/index.d.ts +++ b/types/popper.js/index.d.ts @@ -1,6 +1,9 @@ // Type definitions for popper.js 1.10 // Project: https://github.com/FezVrasta/popper.js/ -// Definitions by: rhysd , joscha , seckardt , marcfallows +// Definitions by: rhysd +// joscha +// seckardt +// marcfallows // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped declare namespace Popper { @@ -100,6 +103,8 @@ declare class Popper { disableEventListeners(): void; } +// Popper.js is globally available directly, but in a module it's only available as a default export. +// tslint:disable-next-line no-single-declare-module no-declare-current-package declare module 'popper.js' { export default Popper; } diff --git a/types/popper.js/tslint.json b/types/popper.js/tslint.json index 59781adedc..fd7e538a58 100644 --- a/types/popper.js/tslint.json +++ b/types/popper.js/tslint.json @@ -1,9 +1,7 @@ { "extends": "dtslint/dt.json", "rules": { - "ban-types": false, - "dt-header": false, - "no-single-declare-module": false, - "no-var": false + // TODO + "ban-types": false } }