From 888c6e79aba5c1fe54123ae2b733d1ca9737e858 Mon Sep 17 00:00:00 2001 From: "Matt R. Wilson" Date: Tue, 28 Nov 2017 08:43:05 -0700 Subject: [PATCH] Fill out `initParams` of `RequestAPI`. This method has the same signature as the verb functions as the args get passed directly to `initParams` from all the verb functions. https://github.com/request/request/blob/master/index.js#L58-L5 --- types/request/index.d.ts | 8 ++++++-- types/request/request-tests.ts | 9 +++++++-- 2 files changed, 13 insertions(+), 4 deletions(-) diff --git a/types/request/index.d.ts b/types/request/index.d.ts index 20ad40e64e..db05b8ebee 100644 --- a/types/request/index.d.ts +++ b/types/request/index.d.ts @@ -5,7 +5,8 @@ // Bart van der Schoor , // Joe Skeen , // Christopher Currens , -// Jon Stevens +// Jon Stevens , +// Matt R. Wilson // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped // TypeScript Version: 2.3 @@ -58,11 +59,14 @@ declare namespace request { delete(uri: string, callback?: RequestCallback): TRequest; delete(options: TUriUrlOptions & TOptions, callback?: RequestCallback): TRequest; + initParams(uri: string, options?: TOptions, callback?: RequestCallback): TRequest; + initParams(uri: string, callback?: RequestCallback): TRequest; + initParams(options: TUriUrlOptions & TOptions, callback?: RequestCallback): TRequest; + forever(agentOptions: any, optionsArg: any): TRequest; jar(store?: any): CookieJar; cookie(str: string): Cookie; - initParams: any; debug: boolean; } diff --git a/types/request/request-tests.ts b/types/request/request-tests.ts index d2c308ed75..0f9d2aa29c 100644 --- a/types/request/request-tests.ts +++ b/types/request/request-tests.ts @@ -161,8 +161,6 @@ req.destroy(); // --- --- --- --- --- --- --- --- --- --- --- --- -value = request.initParams; - req = request(uri); req = request(uri, options); req = request(uri, options, callback); @@ -219,6 +217,13 @@ req = request.delete(uri, callback); req = request.delete(options); req = request.delete(options, callback); +value = request.initParams(uri); +value = request.initParams(uri, options); +value = request.initParams(uri, options, callback); +value = request.initParams(uri, callback); +value = request.initParams(options); +value = request.initParams(options, callback); + req = request.forever(value, value); jar = request.jar(); cookie = request.cookie(str);