From f80774245f4d94eb1e6e1d5b1994929762fa1c76 Mon Sep 17 00:00:00 2001 From: Jared Szechy Date: Thu, 27 Sep 2018 12:24:02 -0400 Subject: [PATCH 1/2] [actioncable] Add missing function to Cable/Consumer interface --- types/actioncable/index.d.ts | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/types/actioncable/index.d.ts b/types/actioncable/index.d.ts index 9194e81d6f..614584a43f 100644 --- a/types/actioncable/index.d.ts +++ b/types/actioncable/index.d.ts @@ -1,7 +1,9 @@ -// Type definitions for ActionCable -// Project: https://github.com/rails/rails/tree/master/actioncable +// Type definitions for ActionCable 5.2 +// Project: https://github.com/rails/rails/tree/master/actioncable/app/assets/javascripts // Definitions by: Vincent Zhu +// Jared Szechy // Definitions: https://github.com/zhu1230/DefinitelyTyped +// TypeScript Version: 2.3 declare module ActionCable { interface Channel { @@ -16,6 +18,10 @@ declare module ActionCable { interface Cable { subscriptions: Subscriptions; + send(data: Object): void; + connect(): void; + disconnect(): void; + ensureActiveConnection(): void; } interface CreateMixin { From dc3a85a6ec2f875275f62df15b76565b7120fd72 Mon Sep 17 00:00:00 2001 From: Jared Szechy Date: Thu, 27 Sep 2018 12:34:15 -0400 Subject: [PATCH 2/2] [actioncable] use any instead of Object --- types/actioncable/index.d.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/types/actioncable/index.d.ts b/types/actioncable/index.d.ts index 614584a43f..b5bdbf429a 100644 --- a/types/actioncable/index.d.ts +++ b/types/actioncable/index.d.ts @@ -9,7 +9,7 @@ declare module ActionCable { interface Channel { unsubscribe(): void; perform(action: string, data: {}): void; - send(data: Object): boolean; + send(data: any): boolean; } interface Subscriptions { @@ -18,7 +18,7 @@ declare module ActionCable { interface Cable { subscriptions: Subscriptions; - send(data: Object): void; + send(data: any): void; connect(): void; disconnect(): void; ensureActiveConnection(): void; @@ -27,7 +27,7 @@ declare module ActionCable { interface CreateMixin { connected(): void; disconnected(): void; - received(obj: Object): void; + received(obj: any): void; [key: string]: Function; }