From 92ec8feb5d00944d5c85039dd7144e06b00b77fd Mon Sep 17 00:00:00 2001 From: Robin Labat Date: Thu, 21 Feb 2019 09:23:58 +0100 Subject: [PATCH 1/2] add subset attribute to ResponderAdvertisement --- types/cote/cote-tests.ts | 4 +++- types/cote/index.d.ts | 7 ++++++- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/types/cote/cote-tests.ts b/types/cote/cote-tests.ts index 1851654625..d4af3ce95e 100644 --- a/types/cote/cote-tests.ts +++ b/types/cote/cote-tests.ts @@ -35,6 +35,7 @@ class Readme { }); const req = { + __subset: 'subset', type: 'randomRequest', payload: { val: Math.floor(Math.random() * 10) @@ -52,7 +53,8 @@ class Readme { name: 'Random Responder', namespace: 'rnd', key: 'a certain key', - respondsTo: ['randomRequest'] + respondsTo: ['randomRequest'], + subset: 'subset' }); interface RandomRequest { diff --git a/types/cote/index.d.ts b/types/cote/index.d.ts index 4c959af76b..a1aafe96b2 100644 --- a/types/cote/index.d.ts +++ b/types/cote/index.d.ts @@ -1,4 +1,4 @@ -// Type definitions for cote 0.17 +// Type definitions for cote 0.19 // Project: https://github.com/dashersw/cote#readme // Definitions by: makepost // Labat Robin @@ -115,6 +115,11 @@ export interface ResponderAdvertisement extends Advertisement { * Request types that a Responder can listen to. */ respondsTo?: string[]; + + /** + * Subset attribut for directed requests. + */ + subset?: string; } export class Publisher extends Component { From 178d30cc0530ab8875551fd660ea6b94f1bae582 Mon Sep 17 00:00:00 2001 From: robin labat Date: Wed, 27 Feb 2019 20:27:26 +0100 Subject: [PATCH 2/2] update on comments --- types/cote/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/cote/index.d.ts b/types/cote/index.d.ts index a1aafe96b2..93f5b7d63f 100644 --- a/types/cote/index.d.ts +++ b/types/cote/index.d.ts @@ -117,7 +117,7 @@ export interface ResponderAdvertisement extends Advertisement { respondsTo?: string[]; /** - * Subset attribut for directed requests. + * Advertisement attribute that lets you target a subgroup of responders using the __subset property of a request. */ subset?: string; }