From 0c79a52bc38e153bfb56fc3ad1cfbce021eecd24 Mon Sep 17 00:00:00 2001 From: Ilya Mochalov Date: Fri, 25 Dec 2015 20:15:49 +0500 Subject: [PATCH] lodash: signatures of _.isNumber have been changed --- lodash/lodash-tests.ts | 42 ++++++++++++++++++++++++++++++------------ lodash/lodash.d.ts | 9 +++++++++ 2 files changed, 39 insertions(+), 12 deletions(-) diff --git a/lodash/lodash-tests.ts b/lodash/lodash-tests.ts index 3f7a26556d..1d211c2ac7 100644 --- a/lodash/lodash-tests.ts +++ b/lodash/lodash-tests.ts @@ -5987,7 +5987,7 @@ module TestIsNaN { } // _.isNative -module TestIsNull { +module TestIsNative { { let value: number|Function; @@ -6040,17 +6040,35 @@ module TestIsNull { } // _.isNumber -result = _.isNumber(any); -result = _(1).isNumber(); -result = _([]).isNumber(); -result = _({}).isNumber(); -{ - let value: number|string = "foo"; - if (_.isNumber(value)) { - let result: number = value * 42; - } else { - let result: string = value; - } +module TestIsNumber { + { + let value: string|number; + + if (_.isNumber(value)) { + let result: number = value; + } + else { + let result: string = value; + } + } + + { + let result: boolean; + + result = _.isNumber(any); + + result = _(1).isNumber(); + result = _([]).isNumber(); + result = _({}).isNumber(); + } + + { + let result: _.LoDashExplicitWrapper; + + result = _(1).chain().isNumber(); + result = _([]).chain().isNumber(); + result = _({}).chain().isNumber(); + } } // _.isObject diff --git a/lodash/lodash.d.ts b/lodash/lodash.d.ts index 584500c101..f0b92ce21a 100644 --- a/lodash/lodash.d.ts +++ b/lodash/lodash.d.ts @@ -10075,7 +10075,9 @@ declare module _ { interface LoDashStatic { /** * Checks if value is classified as a Number primitive or object. + * * Note: To exclude Infinity, -Infinity, and NaN, which are classified as numbers, use the _.isFinite method. + * * @param value The value to check. * @return Returns true if value is correctly classified, else false. */ @@ -10089,6 +10091,13 @@ declare module _ { isNumber(): boolean; } + interface LoDashExplicitWrapperBase { + /** + * see _.isNumber + */ + isNumber(): LoDashExplicitWrapper; + } + //_.isObject interface LoDashStatic { /**