From 0db033ec96f78d1964799f19970641da0854c7f5 Mon Sep 17 00:00:00 2001 From: WEBER Logan Date: Thu, 12 Jul 2018 18:26:49 +0200 Subject: [PATCH] fix(serialport): missing includeDelimiter option for delimiter parser (#27222) Please fill in this template. - [x] Use a meaningful title for the pull request. Include the name of the package modified. - [x] Test the change in your own code. (Compile and run.) - [x] Add or edit tests to reflect the change. (Run with `npm test`.) - [x] Follow the advice from the [readme](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#make-a-pull-request). - [x] Avoid [common mistakes](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#common-mistakes). - [x] Run `npm run lint package-name` (or `tsc` if no `tslint.json` is present). Select one of these and delete the others: If changing an existing definition: - [x] Provide a URL to documentation or source code which provides context for the suggested changes: https://node-serialport.github.io/utilities/parser-delimiter_delimiter.js.html - [ ] Increase the version number in the header if appropriate. - [ ] If you are making substantial changes, consider adding a `tslint.json` containing `{ "extends": "dtslint/dt.json" }`. --- types/serialport/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/serialport/index.d.ts b/types/serialport/index.d.ts index 1e8aa9faa5..2f5f8fc55d 100644 --- a/types/serialport/index.d.ts +++ b/types/serialport/index.d.ts @@ -87,7 +87,7 @@ declare namespace SerialPort { constructor(); } class Delimiter extends Stream.Transform { - constructor(options: {delimiter: string | Buffer | number[]}); + constructor(options: {delimiter: string | Buffer | number[], includeDelimiter?: boolean}); } class Readline extends Delimiter { constructor(options: {delimiter: string | Buffer | number[], encoding?: 'ascii'|'utf8'|'utf16le'|'ucs2'|'base64'|'binary'|'hex'});