From 111a349f751dc0d159acaa404d07f3ababcc354c Mon Sep 17 00:00:00 2001 From: Jesse Trinity <42591254+jessetrinity@users.noreply.github.com> Date: Fri, 7 Feb 2020 16:41:42 -0800 Subject: [PATCH] Revert "chart.js: Update ChartData to accept both Arrays and ReadonlyArrays (#42023)" (#42191) This reverts commit dc72f7ed97fed874bd3ac264ea0c385043efa313. --- types/chart.js/chart.js-tests.ts | 9 --------- types/chart.js/index.d.ts | 4 ++-- 2 files changed, 2 insertions(+), 11 deletions(-) diff --git a/types/chart.js/chart.js-tests.ts b/types/chart.js/chart.js-tests.ts index 8d82393822..3f391ddd5a 100644 --- a/types/chart.js/chart.js-tests.ts +++ b/types/chart.js/chart.js-tests.ts @@ -411,15 +411,6 @@ if (doughnutChart.getDatasetMeta(0).data.length > 0) { console.log(doughnutChartView.y); } -// Passing readonly data as ChartData -const readonlyDataInput: { - labels: ReadonlyArray; - datasets: ReadonlyArray<{ - data: number[]; - }>; -} = { labels: [], datasets: [] }; -const readonlyData: Chart.ChartData = readonlyDataInput; - // Time Cartesian Axis const timeAxisChartData: Chart.ChartData = { datasets: [{ diff --git a/types/chart.js/index.d.ts b/types/chart.js/index.d.ts index 17698d362a..d40d1d8c23 100644 --- a/types/chart.js/index.d.ts +++ b/types/chart.js/index.d.ts @@ -243,8 +243,8 @@ declare namespace Chart { } interface ChartData { - labels?: ReadonlyArray | number | ReadonlyArray | Date | ReadonlyArray | Moment | ReadonlyArray>; - datasets?: ReadonlyArray; + labels?: Array; + datasets?: ChartDataSets[]; } interface RadialChartOptions extends ChartOptions {