From 32a7f958139c8f8e8de75af6918729c8ee6f73f3 Mon Sep 17 00:00:00 2001 From: Quido Hoekman Date: Tue, 12 Sep 2017 06:37:38 +0200 Subject: [PATCH 1/2] Added a new interface Options which includes AuthOptions, because it's no longer compatibel with version ^1.3.5. --- types/nodemailer-mailgun-transport/index.d.ts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/types/nodemailer-mailgun-transport/index.d.ts b/types/nodemailer-mailgun-transport/index.d.ts index 7945f1075f..b8780a26ed 100644 --- a/types/nodemailer-mailgun-transport/index.d.ts +++ b/types/nodemailer-mailgun-transport/index.d.ts @@ -6,12 +6,15 @@ import * as nodemailer from 'nodemailer'; declare namespace mailgunTransport { + interface Options { + auth: AuthOptions + } interface AuthOptions { api_key: string; domain?: string; } } -declare function mailgunTransport(options: mailgunTransport.AuthOptions): nodemailer.Transport; +declare function mailgunTransport(options: mailgunTransport.Options): nodemailer.Transport; export = mailgunTransport; From 5657540e2b53117538d988e098f3640788877ca1 Mon Sep 17 00:00:00 2001 From: Quido Hoekman Date: Tue, 12 Sep 2017 06:53:43 +0200 Subject: [PATCH 2/2] Fixed the tests by using Options instead of AuthOptions directly. --- types/nodemailer-mailgun-transport/index.d.ts | 2 +- .../nodemailer-mailgun-transport-tests.ts | 14 +++++++++----- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/types/nodemailer-mailgun-transport/index.d.ts b/types/nodemailer-mailgun-transport/index.d.ts index b8780a26ed..63db09ae29 100644 --- a/types/nodemailer-mailgun-transport/index.d.ts +++ b/types/nodemailer-mailgun-transport/index.d.ts @@ -7,7 +7,7 @@ import * as nodemailer from 'nodemailer'; declare namespace mailgunTransport { interface Options { - auth: AuthOptions + auth: AuthOptions; } interface AuthOptions { api_key: string; diff --git a/types/nodemailer-mailgun-transport/nodemailer-mailgun-transport-tests.ts b/types/nodemailer-mailgun-transport/nodemailer-mailgun-transport-tests.ts index cdf2a9250c..20ab33766b 100644 --- a/types/nodemailer-mailgun-transport/nodemailer-mailgun-transport-tests.ts +++ b/types/nodemailer-mailgun-transport/nodemailer-mailgun-transport-tests.ts @@ -1,13 +1,17 @@ import mailgunTransport = require('nodemailer-mailgun-transport'); import nodemailer = require('nodemailer'); -const opts: mailgunTransport.AuthOptions = { - api_key: "harry" +const opts: mailgunTransport.Options = { + auth: { + api_key: "harry" + } }; -const optsWithDomain: mailgunTransport.AuthOptions = { - api_key: "harry", - domain: "http://www.foo.com" +const optsWithDomain: mailgunTransport.Options = { + auth: { + api_key: "harry", + domain: "http://www.foo.com" + } }; const transport: nodemailer.Transporter = nodemailer.createTransport(mailgunTransport(optsWithDomain));