From 120fd43ea01f7e9fcdb914514fafa41a2087a0f8 Mon Sep 17 00:00:00 2001 From: Daniel Rentz Date: Mon, 24 Sep 2018 14:55:59 +0200 Subject: [PATCH] "false" is also valid --- types/helmet/helmet-tests.ts | 8 ++++++++ types/helmet/index.d.ts | 8 ++++---- 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/types/helmet/helmet-tests.ts b/types/helmet/helmet-tests.ts index 8b4c5634ac..2c5d582928 100644 --- a/types/helmet/helmet-tests.ts +++ b/types/helmet/helmet-tests.ts @@ -76,6 +76,14 @@ function contentSecurityPolicyTest() { loose: false, setAllHeaders: true })); + app.use(helmet.contentSecurityPolicy({ + directives: { + reportUri: false, + 'report-uri': false, + reportTo: false, + 'report-to': false + } + })); } /** diff --git a/types/helmet/index.d.ts b/types/helmet/index.d.ts index c5048d390f..69b0b7993a 100644 --- a/types/helmet/index.d.ts +++ b/types/helmet/index.d.ts @@ -69,8 +69,8 @@ declare namespace helmet { objectSrc?: HelmetCspDirectiveValue[]; pluginTypes?: HelmetCspDirectiveValue[]; prefetchSrc?: HelmetCspDirectiveValue[]; - reportTo?: HelmetCspDirectiveValue; - reportUri?: HelmetCspDirectiveValue; + reportTo?: HelmetCspDirectiveValue | false; + reportUri?: HelmetCspDirectiveValue | false; requireSriFor?: HelmetCspRequireSriForValue[]; sandbox?: HelmetCspSandboxDirective[]; scriptSrc?: HelmetCspDirectiveValue[]; @@ -95,8 +95,8 @@ declare namespace helmet { 'object-src'?: HelmetCspDirectiveValue[]; 'plugin-types'?: HelmetCspDirectiveValue[]; 'prefetch-src'?: HelmetCspDirectiveValue[]; - 'report-to'?: HelmetCspDirectiveValue; - 'report-uri'?: HelmetCspDirectiveValue; + 'report-to'?: HelmetCspDirectiveValue | false; + 'report-uri'?: HelmetCspDirectiveValue | false; 'require-sri-for'?: HelmetCspRequireSriForValue[]; 'sandbox'?: HelmetCspSandboxDirective[]; 'script-src'?: HelmetCspDirectiveValue;