From 334b07cf44e8e9ba55a57ad3a7e1a82f51566533 Mon Sep 17 00:00:00 2001 From: adelmurzin Date: Tue, 12 Jun 2018 11:40:51 +0300 Subject: [PATCH 1/4] Added type definitions for emoji-regex --- types/emoji-regex/emoji-regex-tests.ts | 3 +++ types/emoji-regex/index.d.ts | 7 +++++++ types/emoji-regex/tsconfig.json | 22 ++++++++++++++++++++++ types/emoji-regex/tslint.json | 1 + 4 files changed, 33 insertions(+) create mode 100644 types/emoji-regex/emoji-regex-tests.ts create mode 100644 types/emoji-regex/index.d.ts create mode 100644 types/emoji-regex/tsconfig.json create mode 100644 types/emoji-regex/tslint.json diff --git a/types/emoji-regex/emoji-regex-tests.ts b/types/emoji-regex/emoji-regex-tests.ts new file mode 100644 index 0000000000..6d6b0d25d9 --- /dev/null +++ b/types/emoji-regex/emoji-regex-tests.ts @@ -0,0 +1,3 @@ +import emojiRegex from "emoji-regex"; + +emojiRegex(); // $ExpectType RegExp diff --git a/types/emoji-regex/index.d.ts b/types/emoji-regex/index.d.ts new file mode 100644 index 0000000000..3eeb3b22fe --- /dev/null +++ b/types/emoji-regex/index.d.ts @@ -0,0 +1,7 @@ +// Type definitions for emoji-regex 7.0 +// Project: https://mths.be/emoji-regex +// Definitions by: iKBAHT +// Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped + +declare const createRegExp: () => RegExp; +export default createRegExp; diff --git a/types/emoji-regex/tsconfig.json b/types/emoji-regex/tsconfig.json new file mode 100644 index 0000000000..619fef592d --- /dev/null +++ b/types/emoji-regex/tsconfig.json @@ -0,0 +1,22 @@ +{ + "compilerOptions": { + "module": "commonjs", + "lib": [ + "es5" + ], + "noImplicitAny": true, + "noImplicitThis": true, + "strictNullChecks": true, + "baseUrl": "../", + "typeRoots": [ + "../" + ], + "types": [], + "noEmit": true, + "forceConsistentCasingInFileNames": true + }, + "files": [ + "index.d.ts", + "emoji-regex-tests.ts" + ] +} diff --git a/types/emoji-regex/tslint.json b/types/emoji-regex/tslint.json new file mode 100644 index 0000000000..3db14f85ea --- /dev/null +++ b/types/emoji-regex/tslint.json @@ -0,0 +1 @@ +{ "extends": "dtslint/dt.json" } From 5cd06d648faefbb7140711b64503990452ba37e0 Mon Sep 17 00:00:00 2001 From: adelmurzin Date: Tue, 12 Jun 2018 12:07:35 +0300 Subject: [PATCH 2/4] added strictFunctionTypes --- types/emoji-regex/tsconfig.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/types/emoji-regex/tsconfig.json b/types/emoji-regex/tsconfig.json index 619fef592d..3ec3f5ac57 100644 --- a/types/emoji-regex/tsconfig.json +++ b/types/emoji-regex/tsconfig.json @@ -2,10 +2,11 @@ "compilerOptions": { "module": "commonjs", "lib": [ - "es5" + "es6" ], "noImplicitAny": true, "noImplicitThis": true, + "strictFunctionTypes": true, "strictNullChecks": true, "baseUrl": "../", "typeRoots": [ From 879f81cc6b9cd3c5bb339f6551879780e09b81f9 Mon Sep 17 00:00:00 2001 From: adelmurzin Date: Tue, 12 Jun 2018 12:07:50 +0300 Subject: [PATCH 3/4] fix for rule prefer-declare-function --- types/emoji-regex/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/emoji-regex/index.d.ts b/types/emoji-regex/index.d.ts index 3eeb3b22fe..736ef54bdd 100644 --- a/types/emoji-regex/index.d.ts +++ b/types/emoji-regex/index.d.ts @@ -3,5 +3,5 @@ // Definitions by: iKBAHT // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped -declare const createRegExp: () => RegExp; +declare function createRegExp(): RegExp; export default createRegExp; From 2b09e0ea8243d20e570f75d715b0a7b4c112a3ad Mon Sep 17 00:00:00 2001 From: adelmurzin Date: Mon, 18 Jun 2018 18:42:30 +0300 Subject: [PATCH 4/4] fixed by review --- types/emoji-regex/index.d.ts | 4 ++-- types/emoji-regex/tsconfig.json | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/types/emoji-regex/index.d.ts b/types/emoji-regex/index.d.ts index 736ef54bdd..edff690dc7 100644 --- a/types/emoji-regex/index.d.ts +++ b/types/emoji-regex/index.d.ts @@ -1,7 +1,7 @@ // Type definitions for emoji-regex 7.0 -// Project: https://mths.be/emoji-regex +// Project: https://github.com/mathiasbynens/emoji-regex // Definitions by: iKBAHT // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped declare function createRegExp(): RegExp; -export default createRegExp; +export = createRegExp; diff --git a/types/emoji-regex/tsconfig.json b/types/emoji-regex/tsconfig.json index 3ec3f5ac57..1dfdf53dac 100644 --- a/types/emoji-regex/tsconfig.json +++ b/types/emoji-regex/tsconfig.json @@ -1,5 +1,6 @@ { "compilerOptions": { + "allowSyntheticDefaultImports": true, "module": "commonjs", "lib": [ "es6"