From 1607336d36c5c01d40300986e6276d46868ce010 Mon Sep 17 00:00:00 2001
From: Connor Fitzgerald <connor.jay.fitzgerald@outlook.com>
Date: Wed, 25 Sep 2019 18:54:00 +0100
Subject: [PATCH] Allow undefined bind parameters (#38496)

---
 types/oracledb/index.d.ts        | 2 +-
 types/oracledb/oracledb-tests.ts | 4 +++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/types/oracledb/index.d.ts b/types/oracledb/index.d.ts
index a1fe79a22c..14fc9fc20a 100644
--- a/types/oracledb/index.d.ts
+++ b/types/oracledb/index.d.ts
@@ -578,7 +578,7 @@ declare namespace OracleDB {
      *
      * @see https://oracle.github.io/node-oracledb/doc/api.html#executebindParams
      */
-    type BindParameters = Record<string, BindParameter | string | number | Date | DBObject | Buffer | null> | BindParameter[] | any[];
+    type BindParameters = Record<string, BindParameter | string | number | Date | DBObject | Buffer | null | undefined> | BindParameter[] | any[];
 
     interface CloseConnectionOptions {
         /**
diff --git a/types/oracledb/oracledb-tests.ts b/types/oracledb/oracledb-tests.ts
index a379387522..eff2abeee7 100644
--- a/types/oracledb/oracledb-tests.ts
+++ b/types/oracledb/oracledb-tests.ts
@@ -143,7 +143,9 @@ const testResultSet = async (connection: oracledb.Connection): Promise<void> =>
             SELECT 2 FROM DUAL
             UNION
             SELECT 3 FROM DUAL`,
-        {},
+        {
+            test: undefined,
+        },
         {
             resultSet: true,
         },