From 18f21659bb12eff534cc29f4ba2aca0ab0680f8e Mon Sep 17 00:00:00 2001
From: samuela <skainsworth@gmail.com>
Date: Wed, 14 Nov 2018 17:49:36 -0800
Subject: [PATCH] [@types/node] ChildProcess `code` and `signal` can be null
 (#30299)

* ChildProcess `code` and `signal` can be null

According to https://github.com/nodejs/node/blob/master/lib/internal/child_process.js#L207 and in particular https://github.com/nodejs/node/blob/master/lib/internal/child_process.js#L246, it's possible for either the `code` or `signal` values to be null.

* add samuela to the authors list

* show some love to the other instances
---
 types/node/index.d.ts | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/types/node/index.d.ts b/types/node/index.d.ts
index ac04693058..06eb076d26 100644
--- a/types/node/index.d.ts
+++ b/types/node/index.d.ts
@@ -31,6 +31,7 @@
 //                 wwwy3y3 <https://github.com/wwwy3y3>
 //                 Zane Hannan AU <https://github.com/ZaneHannanAU>
 //                 Jeremie Rodriguez <https://github.com/jeremiergz>
+//                 Samuel Ainsworth <https://github.com/samuela>
 // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped
 
 /** inspector module types */
@@ -2358,42 +2359,42 @@ declare module "child_process" {
         addListener(event: "close", listener: (code: number, signal: string) => void): this;
         addListener(event: "disconnect", listener: () => void): this;
         addListener(event: "error", listener: (err: Error) => void): this;
-        addListener(event: "exit", listener: (code: number, signal: string) => void): this;
+        addListener(event: "exit", listener: (code: number | null, signal: string | null) => void): this;
         addListener(event: "message", listener: (message: any, sendHandle: net.Socket | net.Server) => void): this;
 
         emit(event: string | symbol, ...args: any[]): boolean;
         emit(event: "close", code: number, signal: string): boolean;
         emit(event: "disconnect"): boolean;
         emit(event: "error", err: Error): boolean;
-        emit(event: "exit", code: number, signal: string): boolean;
+        emit(event: "exit", code: number | null, signal: string | null): boolean;
         emit(event: "message", message: any, sendHandle: net.Socket | net.Server): boolean;
 
         on(event: string, listener: (...args: any[]) => void): this;
         on(event: "close", listener: (code: number, signal: string) => void): this;
         on(event: "disconnect", listener: () => void): this;
         on(event: "error", listener: (err: Error) => void): this;
-        on(event: "exit", listener: (code: number, signal: string) => void): this;
+        on(event: "exit", listener: (code: number | null, signal: string | null) => void): this;
         on(event: "message", listener: (message: any, sendHandle: net.Socket | net.Server) => void): this;
 
         once(event: string, listener: (...args: any[]) => void): this;
         once(event: "close", listener: (code: number, signal: string) => void): this;
         once(event: "disconnect", listener: () => void): this;
         once(event: "error", listener: (err: Error) => void): this;
-        once(event: "exit", listener: (code: number, signal: string) => void): this;
+        once(event: "exit", listener: (code: number | null, signal: string | null) => void): this;
         once(event: "message", listener: (message: any, sendHandle: net.Socket | net.Server) => void): this;
 
         prependListener(event: string, listener: (...args: any[]) => void): this;
         prependListener(event: "close", listener: (code: number, signal: string) => void): this;
         prependListener(event: "disconnect", listener: () => void): this;
         prependListener(event: "error", listener: (err: Error) => void): this;
-        prependListener(event: "exit", listener: (code: number, signal: string) => void): this;
+        prependListener(event: "exit", listener: (code: number | null, signal: string | null) => void): this;
         prependListener(event: "message", listener: (message: any, sendHandle: net.Socket | net.Server) => void): this;
 
         prependOnceListener(event: string, listener: (...args: any[]) => void): this;
         prependOnceListener(event: "close", listener: (code: number, signal: string) => void): this;
         prependOnceListener(event: "disconnect", listener: () => void): this;
         prependOnceListener(event: "error", listener: (err: Error) => void): this;
-        prependOnceListener(event: "exit", listener: (code: number, signal: string) => void): this;
+        prependOnceListener(event: "exit", listener: (code: number | null, signal: string | null) => void): this;
         prependOnceListener(event: "message", listener: (message: any, sendHandle: net.Socket | net.Server) => void): this;
     }