From 2105aaf1fe0eca079227ad2cd76fb9d99aae1007 Mon Sep 17 00:00:00 2001 From: Piotr Roszatycki Date: Wed, 10 Jul 2019 01:29:11 +0200 Subject: [PATCH] node: writableFinished has to be in WriteStream too (#36734) * node: writableFinished is boolean and have to be in WriteStream too * node: add test for process.stdout as Writable --- types/node/globals.d.ts | 1 + types/node/test/global.ts | 11 ++++++++++- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/types/node/globals.d.ts b/types/node/globals.d.ts index 3e8ea8d580..f7395c7db1 100644 --- a/types/node/globals.d.ts +++ b/types/node/globals.d.ts @@ -729,6 +729,7 @@ declare namespace NodeJS { } interface WriteStream extends Socket { + readonly writableFinished: boolean; readonly writableHighWaterMark: number; readonly writableLength: number; columns?: number; diff --git a/types/node/test/global.ts b/types/node/test/global.ts index 8072f34aa7..6d641a09ff 100644 --- a/types/node/test/global.ts +++ b/types/node/test/global.ts @@ -1,4 +1,4 @@ -import { Readable } from 'stream'; +import { Readable, Writable } from 'stream'; { const x: NodeModule = {} as any; @@ -28,3 +28,12 @@ import { Readable } from 'stream'; objectMode: true, }); } + +{ + const stdin: Readable = process.stdin; + let writableFinished: boolean; + const stdout: Writable = process.stdout; + writableFinished = process.stdout.writableFinished; + const stderr: Writable = process.stderr; + writableFinished = process.stderr.writableFinished; +}