From 2194a1ac8b3e83a882b07257a8dfdc94b5fe2b72 Mon Sep 17 00:00:00 2001
From: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
Date: Fri, 10 May 2019 11:02:34 -0700
Subject: [PATCH] fix lodash's Collection.groupBy return type (#35347)

* fix lodash's Collection.groupBy return type

should be

```ts
Object<Dictionary<T[]>>
// not
Object<Dictionary<T>>
```

* Fix String and update tests
---
 types/lodash/ts3.1/common/collection.d.ts |  8 ++++----
 types/lodash/ts3.1/lodash-tests.ts        | 24 +++++++++++------------
 2 files changed, 16 insertions(+), 16 deletions(-)

diff --git a/types/lodash/ts3.1/common/collection.d.ts b/types/lodash/ts3.1/common/collection.d.ts
index 0f782e45c2..693afe54fd 100644
--- a/types/lodash/ts3.1/common/collection.d.ts
+++ b/types/lodash/ts3.1/common/collection.d.ts
@@ -956,13 +956,13 @@ declare module "../index" {
         /**
          * @see _.groupBy
          */
-        groupBy(iteratee?: ValueIteratee<string>): Object<Dictionary<string>>;
+        groupBy(iteratee?: ValueIteratee<string>): Object<Dictionary<string[]>>;
     }
     interface Collection<T> {
         /**
          * @see _.groupBy
          */
-        groupBy(iteratee?: ValueIteratee<T>): Object<Dictionary<T>>;
+        groupBy(iteratee?: ValueIteratee<T>): Object<Dictionary<T[]>>;
     }
     interface Object<T> {
         /**
@@ -974,7 +974,7 @@ declare module "../index" {
         /**
          * @see _.groupBy
          */
-        groupBy(iteratee?: ValueIteratee<string>): ObjectChain<Dictionary<string>>;
+        groupBy(iteratee?: ValueIteratee<string>): ObjectChain<Dictionary<string[]>>;
     }
     interface StringNullableChain {
         /**
@@ -986,7 +986,7 @@ declare module "../index" {
         /**
          * @see _.groupBy
          */
-        groupBy(iteratee?: ValueIteratee<T>): ObjectChain<Dictionary<T>>;
+        groupBy(iteratee?: ValueIteratee<T>): ObjectChain<Dictionary<T[]>>;
     }
     interface ObjectChain<T> {
         /**
diff --git a/types/lodash/ts3.1/lodash-tests.ts b/types/lodash/ts3.1/lodash-tests.ts
index 317a2a6de4..68167331d4 100644
--- a/types/lodash/ts3.1/lodash-tests.ts
+++ b/types/lodash/ts3.1/lodash-tests.ts
@@ -2480,23 +2480,23 @@ _.chain([1, 2, 3, 4]).unshift(5, 6); // $ExpectType CollectionChain<number>
     _.groupBy(dictionary, ""); // $ExpectType Dictionary<AbcObject[]>
     _.groupBy(dictionary, { a: 42 }); // $ExpectType Dictionary<AbcObject[]>
 
-    _("").groupBy(); // $ExpectType Object<Dictionary<string>>
-    _("").groupBy(stringIterator); // $ExpectType Object<Dictionary<string>>
-    _(list).groupBy(); // $ExpectType Object<Dictionary<AbcObject>>
-    _(list).groupBy(valueIterator); // $ExpectType Object<Dictionary<AbcObject>>
-    _(list).groupBy(""); // $ExpectType Object<Dictionary<AbcObject>>
-    _(list).groupBy({ a: 42 }); // $ExpectType Object<Dictionary<AbcObject>>
+    _("").groupBy(); // $ExpectType Object<Dictionary<string[]>>
+    _("").groupBy(stringIterator); // $ExpectType Object<Dictionary<string[]>>
+    _(list).groupBy(); // $ExpectType Object<Dictionary<AbcObject[]>>
+    _(list).groupBy(valueIterator); // $ExpectType Object<Dictionary<AbcObject[]>>
+    _(list).groupBy(""); // $ExpectType Object<Dictionary<AbcObject[]>>
+    _(list).groupBy({ a: 42 }); // $ExpectType Object<Dictionary<AbcObject[]>>
     _(dictionary).groupBy(); // $ExpectType Object<Dictionary<AbcObject[]>>
     _(dictionary).groupBy(valueIterator); // $ExpectType Object<Dictionary<AbcObject[]>>
     _(dictionary).groupBy(""); // $ExpectType Object<Dictionary<AbcObject[]>>
     _(dictionary).groupBy({ a: 42 }); // $ExpectType Object<Dictionary<AbcObject[]>>
 
-    _.chain("").groupBy(); // $ExpectType ObjectChain<Dictionary<string>>
-    _.chain("").groupBy(stringIterator); // $ExpectType ObjectChain<Dictionary<string>>
-    _.chain(list).groupBy(); // $ExpectType ObjectChain<Dictionary<AbcObject>>
-    _.chain(list).groupBy(valueIterator); // $ExpectType ObjectChain<Dictionary<AbcObject>>
-    _.chain(list).groupBy(""); // $ExpectType ObjectChain<Dictionary<AbcObject>>
-    _.chain(list).groupBy({ a: 42 }); // $ExpectType ObjectChain<Dictionary<AbcObject>>
+    _.chain("").groupBy(); // $ExpectType ObjectChain<Dictionary<string[]>>
+    _.chain("").groupBy(stringIterator); // $ExpectType ObjectChain<Dictionary<string[]>>
+    _.chain(list).groupBy(); // $ExpectType ObjectChain<Dictionary<AbcObject[]>>
+    _.chain(list).groupBy(valueIterator); // $ExpectType ObjectChain<Dictionary<AbcObject[]>>
+    _.chain(list).groupBy(""); // $ExpectType ObjectChain<Dictionary<AbcObject[]>>
+    _.chain(list).groupBy({ a: 42 }); // $ExpectType ObjectChain<Dictionary<AbcObject[]>>
     _.chain(dictionary).groupBy(); // $ExpectType ObjectChain<Dictionary<AbcObject[]>>
     _.chain(dictionary).groupBy(valueIterator); // $ExpectType ObjectChain<Dictionary<AbcObject[]>>
     _.chain(dictionary).groupBy(""); // $ExpectType ObjectChain<Dictionary<AbcObject[]>>