From 36daff0a635274083f15352d3d460be8bd8ef68c Mon Sep 17 00:00:00 2001 From: Priscila Moneo Date: Tue, 29 Jan 2019 13:28:54 -0300 Subject: [PATCH 1/6] Added missing props to type definition --- types/reactable/index.d.ts | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/types/reactable/index.d.ts b/types/reactable/index.d.ts index 5a6b80317d..4b0bb16b8d 100644 --- a/types/reactable/index.d.ts +++ b/types/reactable/index.d.ts @@ -1,8 +1,8 @@ // Type definitions for reactable 0.14 // Project: https://github.com/glittershark/reactable -// Definitions by: Christoph Spielmann +// Definitions by: Christoph Spielmann , Priscila Moneo // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped -// TypeScript Version: 2.8 +// TypeScript Version: 3.1.6 import * as React from 'react'; @@ -23,10 +23,16 @@ export interface TableComponentProperties { columns?: ColumnsType[]; defaultSort?: { column: string, direction: SortDirection }; id?: string; - sortable?: string[]; + sortable?: string[] | boolean; + sortBy?: boolean; filterable?: string[]; filterBy?: string; onFilter?: FilterMethodType; + itemsPerPage?: number; + noDataText?: string; + pageButtonLimit?: number; + currentPage?: number; + hideFilterInput?: boolean; } export interface ThProperties { @@ -61,4 +67,4 @@ export class Td extends React.Component { } export class Tfoot extends React.Component { -} +} \ No newline at end of file From 7373ac8dbeb8f8b7608d63249332b5273f729987 Mon Sep 17 00:00:00 2001 From: Priscila Moneo Date: Tue, 29 Jan 2019 13:28:54 -0300 Subject: [PATCH 2/6] Added missing props to type definition --- types/reactable/index.d.ts | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/types/reactable/index.d.ts b/types/reactable/index.d.ts index 5a6b80317d..70ec431fc5 100644 --- a/types/reactable/index.d.ts +++ b/types/reactable/index.d.ts @@ -1,6 +1,6 @@ // Type definitions for reactable 0.14 // Project: https://github.com/glittershark/reactable -// Definitions by: Christoph Spielmann +// Definitions by: Christoph Spielmann , Priscila Moneo // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped // TypeScript Version: 2.8 @@ -23,10 +23,16 @@ export interface TableComponentProperties { columns?: ColumnsType[]; defaultSort?: { column: string, direction: SortDirection }; id?: string; - sortable?: string[]; + sortable?: string[] | boolean; + sortBy?: boolean; filterable?: string[]; filterBy?: string; onFilter?: FilterMethodType; + itemsPerPage?: number; + noDataText?: string; + pageButtonLimit?: number; + currentPage?: number; + hideFilterInput?: boolean; } export interface ThProperties { @@ -61,4 +67,4 @@ export class Td extends React.Component { } export class Tfoot extends React.Component { -} +} \ No newline at end of file From 1e4c27aeab4e19bbaa9a4dc143f78f92ece73e8d Mon Sep 17 00:00:00 2001 From: Priscila Moneo Date: Tue, 29 Jan 2019 13:50:03 -0300 Subject: [PATCH 3/6] Changed version --- types/reactable/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/reactable/index.d.ts b/types/reactable/index.d.ts index 4b0bb16b8d..70ec431fc5 100644 --- a/types/reactable/index.d.ts +++ b/types/reactable/index.d.ts @@ -2,7 +2,7 @@ // Project: https://github.com/glittershark/reactable // Definitions by: Christoph Spielmann , Priscila Moneo // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped -// TypeScript Version: 3.1.6 +// TypeScript Version: 2.8 import * as React from 'react'; From e09f3e341ffd63bf69d81cac5ea8b31ef36ab3fb Mon Sep 17 00:00:00 2001 From: Priscila Moneo Date: Tue, 29 Jan 2019 13:56:50 -0300 Subject: [PATCH 4/6] removed typescript version --- types/reactable/index.d.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/types/reactable/index.d.ts b/types/reactable/index.d.ts index 70ec431fc5..39d0428850 100644 --- a/types/reactable/index.d.ts +++ b/types/reactable/index.d.ts @@ -2,7 +2,6 @@ // Project: https://github.com/glittershark/reactable // Definitions by: Christoph Spielmann , Priscila Moneo // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped -// TypeScript Version: 2.8 import * as React from 'react'; From 0c29b781af77f78217ce6b294a2e564e67d60684 Mon Sep 17 00:00:00 2001 From: Priscila Moneo Date: Tue, 29 Jan 2019 13:57:38 -0300 Subject: [PATCH 5/6] Added newline --- types/reactable/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/reactable/index.d.ts b/types/reactable/index.d.ts index 39d0428850..ea2f0117d4 100644 --- a/types/reactable/index.d.ts +++ b/types/reactable/index.d.ts @@ -66,4 +66,4 @@ export class Td extends React.Component { } export class Tfoot extends React.Component { -} \ No newline at end of file +} From 176099096219761c1ff2b998f5c566eb17e7bd45 Mon Sep 17 00:00:00 2001 From: Priscila Moneo Date: Tue, 29 Jan 2019 14:02:06 -0300 Subject: [PATCH 6/6] Added typescript version --- types/reactable/index.d.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/types/reactable/index.d.ts b/types/reactable/index.d.ts index ea2f0117d4..ed620a194c 100644 --- a/types/reactable/index.d.ts +++ b/types/reactable/index.d.ts @@ -2,6 +2,7 @@ // Project: https://github.com/glittershark/reactable // Definitions by: Christoph Spielmann , Priscila Moneo // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped +// TypeScript Version: 2.8 import * as React from 'react';