From 50457822da5ee4998df7b7820956edaea2ea2607 Mon Sep 17 00:00:00 2001 From: Maurice de Beijer Date: Tue, 28 Aug 2018 10:20:07 +0200 Subject: [PATCH 1/2] Added missing React options for i18next --- types/i18next/index.d.ts | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/types/i18next/index.d.ts b/types/i18next/index.d.ts index 7674762de6..205f87f6e1 100644 --- a/types/i18next/index.d.ts +++ b/types/i18next/index.d.ts @@ -97,10 +97,12 @@ declare namespace i18next { interface ReactOptions { /** * set to true if you like to wait for loaded in every translated hoc + * @default false */ wait?: boolean; /** * set it to fallback to let passed namespaces to translated hoc act as fallbacks + * @default default */ nsMode?: string; /** @@ -108,6 +110,16 @@ declare namespace i18next { * @default div */ defaultTransParent?: string; + /** + * set which events trigger a rerender, can be set to false or string of events + * @default languageChanged loaded + */ + bindI18n?: string | boolean; + /** + * set which events on store trigger a rerender, can be set to false or string of events + * @default added removed + */ + bindStore?: string | boolean; } interface InitOptions { From 75ac903b6079bf972e5b3694094995a24a1d6898 Mon Sep 17 00:00:00 2001 From: Maurice de Beijer Date: Tue, 28 Aug 2018 11:39:36 +0200 Subject: [PATCH 2/2] Updates after review comments --- types/i18next/index.d.ts | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/types/i18next/index.d.ts b/types/i18next/index.d.ts index 205f87f6e1..484745bcad 100644 --- a/types/i18next/index.d.ts +++ b/types/i18next/index.d.ts @@ -102,24 +102,24 @@ declare namespace i18next { wait?: boolean; /** * set it to fallback to let passed namespaces to translated hoc act as fallbacks - * @default default + * @default 'default' */ - nsMode?: string; + nsMode?: 'default' | 'fallback'; /** * set it to the default parent element created by the Trans component. - * @default div + * @default 'div' */ defaultTransParent?: string; /** * set which events trigger a rerender, can be set to false or string of events - * @default languageChanged loaded + * @default 'languageChanged loaded' */ - bindI18n?: string | boolean; + bindI18n?: string | false; /** * set which events on store trigger a rerender, can be set to false or string of events - * @default added removed + * @default 'added removed' */ - bindStore?: string | boolean; + bindStore?: string | false; } interface InitOptions {