From 239dc996ad247fdda1c39e24bbb0efcdc7c44e6f Mon Sep 17 00:00:00 2001 From: Andy Date: Mon, 24 Sep 2018 09:13:57 -0700 Subject: [PATCH] rot-js: Fix lint (#29103) * rot-js: Fix lint * Improve type --- types/rot-js/index.d.ts | 3 ++- types/rot-js/rot-js-tests.ts | 3 +++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/types/rot-js/index.d.ts b/types/rot-js/index.d.ts index f2d0b45592..e44ec88014 100644 --- a/types/rot-js/index.d.ts +++ b/types/rot-js/index.d.ts @@ -2,6 +2,7 @@ // Project: https://github.com/ondras/rot.js // Definitions by: Roger Ostrander // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped +// TypeScript Version: 2.1 // Extensions (thanks, https://www.typescriptlang.org/docs/handbook/declaration-files/templates/global-modifying-module-d-ts.html ) declare global { @@ -353,7 +354,7 @@ export interface RNGable { getUniformInt(lowerBound: number, upperBound: number): number; getNormal(mean?: number, stddev?: number): number; getPercentage(): number; - getWeightedValue(data: { T: number }): T; + getWeightedValue(data: Record): K; getState(): [number, number, number, number]; setState(state: [number, number, number, number]): RNGable; clone(): RNGable; diff --git a/types/rot-js/rot-js-tests.ts b/types/rot-js/rot-js-tests.ts index 36f6aa3576..8edb638466 100644 --- a/types/rot-js/rot-js-tests.ts +++ b/types/rot-js/rot-js-tests.ts @@ -160,6 +160,9 @@ ROT.RNG.setSeed(123); SHOW(ROT.RNG.getUniform()); SHOW(clone.getUniform()); +clone.getWeightedValue({} as any); // $ExpectType string +clone.getWeightedValue({ a: 1, b: 2 }); // $ExpectType "a" | "b" + // RNG / Picking a weighted value const monsters = { orc: 3,