From b5ef7d4ac7e8ea418d4e8a2edc070e08bd0431d4 Mon Sep 17 00:00:00 2001 From: Tim Bureck Date: Sat, 14 Feb 2015 01:30:56 +0100 Subject: [PATCH 1/5] Create jBinary.d.ts --- jBinary/jBinary.d.ts | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) create mode 100644 jBinary/jBinary.d.ts diff --git a/jBinary/jBinary.d.ts b/jBinary/jBinary.d.ts new file mode 100644 index 0000000000..b9b28b0c74 --- /dev/null +++ b/jBinary/jBinary.d.ts @@ -0,0 +1,32 @@ +// Type definitions for jBinary +// Project: https://github.com/jDataView/jBinary +// Definitions by: Tim Bureck +// Definitions: https://github.com/borisyankov/DefinitelyTyped + +// Additional notes: +// Method stubs and types are taken from the official jBinary documentation, which can be found here: +// https://github.com/jDataView/jBinary/wiki/jBinary-Constructor +// https://github.com/jDataView/jBinary/wiki/jBinary-Methods + +/// + +declare class jBinary +{ + + constructor(data:Array); + constructor(data:jDataView, typeSet:Object); + constructor(bufferSize:number, typeSet:Object); + + read(type:string, offset:number = this.tell()):any; + readAll():any; + + write(type:string, data:any, offset:number = this.tell()); + writeAll(data:any); + + tell():number; + seek(position:number, callback):number; + skip(count:number, callback):number; + + slice(start:number, end:number, forceCopy:boolean = false):jBinary; + as(typeSet:Object, modifyOriginal:boolean = false):jBinary; +} \ No newline at end of file From 56c5256ed072e5855c519bf237e763be847aa9d5 Mon Sep 17 00:00:00 2001 From: Tim Bureck Date: Sun, 15 Feb 2015 13:38:42 +0100 Subject: [PATCH 2/5] TS 1.4.1 fixes in jBinary.d.ts --- jBinary/jBinary.d.ts | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/jBinary/jBinary.d.ts b/jBinary/jBinary.d.ts index b9b28b0c74..98b0fc4d62 100644 --- a/jBinary/jBinary.d.ts +++ b/jBinary/jBinary.d.ts @@ -17,16 +17,16 @@ declare class jBinary constructor(data:jDataView, typeSet:Object); constructor(bufferSize:number, typeSet:Object); - read(type:string, offset:number = this.tell()):any; + read(type:string, offset?:number):any; readAll():any; - write(type:string, data:any, offset:number = this.tell()); - writeAll(data:any); + write(type:string, data:any, offset?:number):number; + writeAll(data:any):number; tell():number; seek(position:number, callback):number; skip(count:number, callback):number; - slice(start:number, end:number, forceCopy:boolean = false):jBinary; - as(typeSet:Object, modifyOriginal:boolean = false):jBinary; + slice(start:number, end:number, forceCopy?:boolean):jBinary; + as(typeSet:Object, modifyOriginal?:boolean):jBinary; } \ No newline at end of file From a78835ccff389eecc080b8f6a67a600183f1c417 Mon Sep 17 00:00:00 2001 From: Tim Bureck Date: Sun, 15 Feb 2015 13:44:43 +0100 Subject: [PATCH 3/5] Fixed missing type hinting for callback parameters in seek() and skip() methods in jBinary.d.ts --- jBinary/jBinary.d.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/jBinary/jBinary.d.ts b/jBinary/jBinary.d.ts index 98b0fc4d62..cf57d5f777 100644 --- a/jBinary/jBinary.d.ts +++ b/jBinary/jBinary.d.ts @@ -24,8 +24,8 @@ declare class jBinary writeAll(data:any):number; tell():number; - seek(position:number, callback):number; - skip(count:number, callback):number; + seek(position:number, callback: (prop:jBinary, data:any) => any):number; + skip(count:number, callback: (prop:jBinary, data:any) => any):number; slice(start:number, end:number, forceCopy?:boolean):jBinary; as(typeSet:Object, modifyOriginal?:boolean):jBinary; From 971afd9fc30b077ba047a3c82cc94296034df906 Mon Sep 17 00:00:00 2001 From: Tim Bureck Date: Mon, 16 Feb 2015 20:13:39 +0100 Subject: [PATCH 4/5] Removed jBinary.d.ts as preparation for renaming to lower cased name (workaround for Windows problems I suppose) --- jBinary/jBinary.d.ts | 32 -------------------------------- 1 file changed, 32 deletions(-) delete mode 100644 jBinary/jBinary.d.ts diff --git a/jBinary/jBinary.d.ts b/jBinary/jBinary.d.ts deleted file mode 100644 index cf57d5f777..0000000000 --- a/jBinary/jBinary.d.ts +++ /dev/null @@ -1,32 +0,0 @@ -// Type definitions for jBinary -// Project: https://github.com/jDataView/jBinary -// Definitions by: Tim Bureck -// Definitions: https://github.com/borisyankov/DefinitelyTyped - -// Additional notes: -// Method stubs and types are taken from the official jBinary documentation, which can be found here: -// https://github.com/jDataView/jBinary/wiki/jBinary-Constructor -// https://github.com/jDataView/jBinary/wiki/jBinary-Methods - -/// - -declare class jBinary -{ - - constructor(data:Array); - constructor(data:jDataView, typeSet:Object); - constructor(bufferSize:number, typeSet:Object); - - read(type:string, offset?:number):any; - readAll():any; - - write(type:string, data:any, offset?:number):number; - writeAll(data:any):number; - - tell():number; - seek(position:number, callback: (prop:jBinary, data:any) => any):number; - skip(count:number, callback: (prop:jBinary, data:any) => any):number; - - slice(start:number, end:number, forceCopy?:boolean):jBinary; - as(typeSet:Object, modifyOriginal?:boolean):jBinary; -} \ No newline at end of file From ae77785d1cf23f6380e37bde2d6bb98c64bf503d Mon Sep 17 00:00:00 2001 From: Tim Bureck Date: Mon, 16 Feb 2015 20:15:26 +0100 Subject: [PATCH 5/5] * Renamed file to match contribution guidelines * Added simple tests-file * Made callback parameters in seek() and skip() optional --- jbinary/jbinary-tests.ts | 16 ++++++++++++++++ jbinary/jbinary.d.ts | 32 ++++++++++++++++++++++++++++++++ 2 files changed, 48 insertions(+) create mode 100644 jbinary/jbinary-tests.ts create mode 100644 jbinary/jbinary.d.ts diff --git a/jbinary/jbinary-tests.ts b/jbinary/jbinary-tests.ts new file mode 100644 index 0000000000..c1e286fce4 --- /dev/null +++ b/jbinary/jbinary-tests.ts @@ -0,0 +1,16 @@ +/// + +var originalData = [0x05, 0x03, 0x7F, 0x1E]; +var b1 = new jBinary(originalData); +console.log(b1.readAll()); +console.log(b1.read('int8')); + +b1.seek(4); +console.log(b1.read('int8')); + +console.log(b1.tell()); + +b1.write('int8', 0x9A, 2); +b1.writeAll(originalData); + +console.log(b1.slice(0, 2)); diff --git a/jbinary/jbinary.d.ts b/jbinary/jbinary.d.ts new file mode 100644 index 0000000000..f9a2f2aaa9 --- /dev/null +++ b/jbinary/jbinary.d.ts @@ -0,0 +1,32 @@ +// Type definitions for jBinary +// Project: https://github.com/jDataView/jBinary +// Definitions by: Tim Bureck +// Definitions: https://github.com/borisyankov/DefinitelyTyped + +// Additional notes: +// Method stubs and types are taken from the official jBinary documentation, which can be found here: +// https://github.com/jDataView/jBinary/wiki/jBinary-Constructor +// https://github.com/jDataView/jBinary/wiki/jBinary-Methods + +/// + +declare class jBinary +{ + + constructor(data:Array); + constructor(data:jDataView, typeSet:Object); + constructor(bufferSize:number, typeSet:Object); + + read(type:string, offset?:number):any; + readAll():any; + + write(type:string, data:any, offset?:number):number; + writeAll(data:any):number; + + tell():number; + seek(position:number, callback?: (prop:jBinary, data:any) => any):number; + skip(count:number, callback?: (prop:jBinary, data:any) => any):number; + + slice(start:number, end:number, forceCopy?:boolean):jBinary; + as(typeSet:Object, modifyOriginal?:boolean):jBinary; +} \ No newline at end of file