From 273c8be397abaebefbd091e60ef91badd3d7a43c Mon Sep 17 00:00:00 2001 From: Lucas Garron Date: Wed, 10 Oct 2018 12:53:43 -0700 Subject: [PATCH] webauthn: Mark `rpId` and `allowCredentials` as optional for `PublicKeyCredentialRequestOptions`. (#29463) As documented at https://w3c.github.io/webauthn/#dictdef-publickeycredentialrequestoptions (already linked in the comment for the interface), the the `rpId` and and `allowCredentials` fields are optional. --- types/webappsec-credential-management/index.d.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/types/webappsec-credential-management/index.d.ts b/types/webappsec-credential-management/index.d.ts index a0498f34af..3c608e2202 100644 --- a/types/webappsec-credential-management/index.d.ts +++ b/types/webappsec-credential-management/index.d.ts @@ -392,8 +392,8 @@ type UserVerificationRequirement = "required" | "preferred" | "discouraged"; interface PublicKeyCredentialRequestOptions { challenge: BufferSource; timeout: number; - rpId: string; - allowCredentials: PublicKeyCredentialDescriptor[]; + rpId?: string; + allowCredentials?: PublicKeyCredentialDescriptor[]; userVerification?: UserVerificationRequirement; extensions?: any; }