From 2a629ed0c2aeee7525c769c1a2bb7c79d987fbc9 Mon Sep 17 00:00:00 2001 From: Vu Tran Date: Wed, 24 Apr 2019 10:24:32 -0700 Subject: [PATCH] [react-aria-menubutton] Extend React.HTMLProps (#34920) This PR each component's interface to extend `React.HTMLProps` instead of `React.HTMLAttributes` so `ref` can be passed down. --- types/react-aria-menubutton/index.d.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/types/react-aria-menubutton/index.d.ts b/types/react-aria-menubutton/index.d.ts index dc3d975d64..4c068e6031 100644 --- a/types/react-aria-menubutton/index.d.ts +++ b/types/react-aria-menubutton/index.d.ts @@ -13,7 +13,7 @@ export interface WrapperState { } export interface WrapperProps - extends React.HTMLAttributes { + extends React.HTMLProps { /** * A callback to run when the user makes a selection * (i.e. clicks or presses Enter or Space on a `MenuItem`). @@ -58,7 +58,7 @@ export interface WrapperProps export class Wrapper extends React.Component> {} export interface ButtonProps - extends React.HTMLAttributes { + extends React.HTMLProps { /** * If true, the element is disabled * (aria-disabled='true', not in tab order, clicking has no effect). @@ -82,7 +82,7 @@ export interface ButtonProps export class Button extends React.Component> {} export interface MenuProps - extends React.HTMLAttributes { + extends React.HTMLProps { /** * The HTML tag for this element. Default: 'span'. */ @@ -95,7 +95,7 @@ export interface MenuProps export class Menu extends React.Component> {} export interface MenuItemProps - extends React.HTMLAttributes { + extends React.HTMLProps { /** * If value has a value, it will be passed to the onSelection handler * when the `MenuItem` is selected