From 2a7deeea29c4806f6e77a6bbfff9a2801152aecf Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Piotr=20B=C5=82a=C5=BCejewicz=20=28Peter=20Blazejewicz=29?= Date: Thu, 23 Jan 2020 23:26:47 +0100 Subject: [PATCH] fix(carbon-components-react): `title` prop of the AccordionItem. Closes #41811 (#41825) * fix(carbon-components-react): `title` of AccordionItem. Closes #41811 - redeclare `title` property to supports React.Node Thanks! * Update types/carbon-components-react/lib/components/Accordion/AccordionItem.d.ts thx to @kalbert312 Co-Authored-By: Kyle Albert <5498623+kalbert312@users.noreply.github.com> Co-authored-by: Kyle Albert <5498623+kalbert312@users.noreply.github.com> --- .../carbon-components-react-tests.tsx | 19 +++++++++++++++++++ .../components/Accordion/AccordionItem.d.ts | 4 +++- 2 files changed, 22 insertions(+), 1 deletion(-) diff --git a/types/carbon-components-react/carbon-components-react-tests.tsx b/types/carbon-components-react/carbon-components-react-tests.tsx index fd63b7a789..40af3c8a9a 100644 --- a/types/carbon-components-react/carbon-components-react-tests.tsx +++ b/types/carbon-components-react/carbon-components-react-tests.tsx @@ -1,5 +1,6 @@ import * as React from 'react'; import { + AccordionItem, DataTable, DataTableHeader, DataTableRow, @@ -10,6 +11,24 @@ import { } from 'carbon-components-react'; import Link from 'carbon-components-react/lib/components/UIShell/Link'; +// AccordionItem +const titleNode = ( +

+ SomethingA heading +

+); +const accordionItemOne = ( + + Lorem ipsum. + +); +const accordionTitle = 'Hello World!'; +const accordionItemTwo = ( + + Lorem ipsum. + +); + interface Row1 extends DataTableRow { rowProp: string; } diff --git a/types/carbon-components-react/lib/components/Accordion/AccordionItem.d.ts b/types/carbon-components-react/lib/components/Accordion/AccordionItem.d.ts index 12ee397675..f54d4a6140 100644 --- a/types/carbon-components-react/lib/components/Accordion/AccordionItem.d.ts +++ b/types/carbon-components-react/lib/components/Accordion/AccordionItem.d.ts @@ -8,10 +8,12 @@ export interface HeadingClickData { isOpen: boolean; } -export interface AccordionItemProps extends InheritedProps { +export interface AccordionItemProps extends Omit { onHeadingClick?(data: HeadingClickData): void, open?: boolean, renderExpando?: React.ReactNode, + /** The accordion title. */ + title?: React.ReactNode; } declare class AccordionItem extends React.Component { }