From ed9659ac6e191af8a60f037204166a8edf2e5396 Mon Sep 17 00:00:00 2001 From: Adam Vigneaux Date: Fri, 15 Jun 2018 15:57:19 -0400 Subject: [PATCH 1/3] Add missing properties to DateOptions --- types/chance/index.d.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/types/chance/index.d.ts b/types/chance/index.d.ts index 07418e45be..05d388b97a 100644 --- a/types/chance/index.d.ts +++ b/types/chance/index.d.ts @@ -189,6 +189,8 @@ declare namespace Chance { year?: number; month?: number; day?: number; + min?: Date; + max?: Date; } interface Month { From 05b4d723a347134f087a2fd831135bdbd26fc4aa Mon Sep 17 00:00:00 2001 From: Adam Vigneaux Date: Fri, 15 Jun 2018 16:09:49 -0400 Subject: [PATCH 2/3] Bump Chance version number --- types/chance/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/chance/index.d.ts b/types/chance/index.d.ts index 05d388b97a..17708acc5a 100644 --- a/types/chance/index.d.ts +++ b/types/chance/index.d.ts @@ -1,4 +1,4 @@ -// Type definitions for Chance 1.0.13 +// Type definitions for Chance 1.0.16 // Project: http://chancejs.com // Definitions by: Chris Bowdon // Brice BERNARD From 3a2e7d636f7cff39cab32ea124189b457024e72e Mon Sep 17 00:00:00 2001 From: Adam Vigneaux Date: Fri, 15 Jun 2018 16:10:05 -0400 Subject: [PATCH 3/3] Add tests for chance.date() min and max properties --- types/chance/chance-tests.ts | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/types/chance/chance-tests.ts b/types/chance/chance-tests.ts index 00d8752118..238fd97cf3 100644 --- a/types/chance/chance-tests.ts +++ b/types/chance/chance-tests.ts @@ -71,3 +71,18 @@ euro = chance.euro({opt: 'abc'}); let coin = chance.coin(); coin = chance.coin(); + +// Make sure date works with min and max parameters +let date: string|Date = chance.date(); + +let min = new Date(); +let max = new Date(); +date = chance.date({min, max}); + +min = new Date(); +min.setFullYear(new Date().getFullYear() - 15); +max = new Date(); +max.setFullYear(new Date().getFullYear() + 15); +date = chance.date({min, max}); +date = chance.date({min}); +date = chance.date({max});