From 2b651d9c4f4e47dacffb998986a0facbfe12cea7 Mon Sep 17 00:00:00 2001 From: Christian Date: Tue, 2 Oct 2018 06:02:28 +0200 Subject: [PATCH] fix(ember__error): make EmberError extendable (#29337) --- types/ember/index.d.ts | 2 +- types/ember__error/ember__error-tests.ts | 6 +++++- types/ember__error/index.d.ts | 2 +- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/types/ember/index.d.ts b/types/ember/index.d.ts index 5a988c118c..fdb89d3823 100755 --- a/types/ember/index.d.ts +++ b/types/ember/index.d.ts @@ -228,7 +228,7 @@ export namespace Ember { /** * A subclass of the JavaScript Error object for use in Ember. */ - const Error: EmberError; + const Error: typeof EmberError; const Evented: typeof EmberObjectEventedNs.default; diff --git a/types/ember__error/ember__error-tests.ts b/types/ember__error/ember__error-tests.ts index a5e605cfee..503d16ee5a 100644 --- a/types/ember__error/ember__error-tests.ts +++ b/types/ember__error/ember__error-tests.ts @@ -1,3 +1,7 @@ import Error from '@ember/error'; -new Error('Fuuuuuuuu'); // $ExpectType Error +new Error('Fuuuuuuuu'); // $ExpectType EmberError + +// allows to extend from EmberError +class AjaxError extends Error { +} diff --git a/types/ember__error/index.d.ts b/types/ember__error/index.d.ts index 1526379547..312b1c3334 100644 --- a/types/ember__error/index.d.ts +++ b/types/ember__error/index.d.ts @@ -7,4 +7,4 @@ /** * A subclass of the JavaScript Error object for use in Ember. */ -export default ErrorConstructor; +export default class EmberError extends Error {}