From 2b902bfe59c6dfd3b597f8518ffcb2ccda1787af Mon Sep 17 00:00:00 2001 From: jacobbogers Date: Fri, 19 May 2017 12:25:25 +0200 Subject: [PATCH] changed recommended by tslint break other projects (mongo-store) depending on this declaration, so reverted --- types/express-session/index.d.ts | 42 ++++++++++++++--------------- types/express-session/tsconfig.json | 2 +- 2 files changed, 22 insertions(+), 22 deletions(-) diff --git a/types/express-session/index.d.ts b/types/express-session/index.d.ts index e3f5b25a08..60dedea20a 100644 --- a/types/express-session/index.d.ts +++ b/types/express-session/index.d.ts @@ -24,7 +24,7 @@ declare global { interface SessionCookieData { originalMaxAge: number; path: string; - maxAge: number; + maxAge: number | null; secure?: boolean; httpOnly: boolean; domain?: string; @@ -64,35 +64,35 @@ declare namespace session { } interface BaseMemoryStore { - get(sid: string, callback: (err: any, session: Express.Session) => void): void; - set(sid: string, session: Express.Session, callback: (err: any) => void): void; - destroy(sid: string, callback: (err: any) => void): void; - length?(callback: (err: any, length: number) => void): void; - clear?(callback: (err: any) => void): void; + get: (sid: string, callback: (err: any, session: Express.Session) => void) => void; + set: (sid: string, session: Express.Session, callback: (err: any) => void) => void; + destroy: (sid: string, callback: (err: any) => void) => void; + length?: (callback: (err: any, length: number) => void) => void; + clear?: (callback: (err: any) => void) => void; } abstract class Store extends node.EventEmitter { constructor(config?: any); - regenerate(req: express.Request, fn: (err: any) => any): void; - load(sid: string, fn: (err: any, session: Express.Session) => any): void; - createSession(req: express.Request, sess: Express.SessionData): void; + regenerate: (req: express.Request, fn: (err: any) => any) => void; + load: (sid: string, fn: (err: any, session: Express.Session) => any) => void; + createSession: (req: express.Request, sess: Express.SessionData) => void; - get(sid: string, callback: (err: any, session: Express.Session) => void): void; - set(sid: string, session: Express.Session, callback: (err: any) => void): void; - destroy(sid: string, callback: (err: any) => void): void; - all(callback: (err: any, obj: { [sid: string]: Express.SessionData; }) => void): void; - length(callback: (err: any, length: number) => void): void; - clear(callback: (err: any) => void): void; + get: (sid: string, callback: (err: any, session: Express.Session) => void) => void; + set: (sid: string, session: Express.Session, callback: (err: any) => void) => void; + destroy: (sid: string, callback: (err: any) => void) => void; + all: (callback: (err: any, obj: { [sid: string]: Express.SessionData; }) => void) => void; + length: (callback: (err: any, length: number) => void) => void; + clear: (callback: (err: any) => void) => void; } class MemoryStore implements BaseMemoryStore { - get(sid: string, callback: (err: any, session: Express.Session) => void): void; - set(sid: string, session: Express.Session, callback: (err: any) => void): void; - destroy(sid: string, callback: (err: any) => void): void; - all(callback: (err: any, obj: { [sid: string]: Express.Session; }) => void): void; - length(callback: (err: any, length: number) => void): void; - clear(callback: (err: any) => void): void; + get: (sid: string, callback: (err: any, session: Express.Session) => void) => void; + set: (sid: string, session: Express.Session, callback: (err: any) => void) => void; + destroy: (sid: string, callback: (err: any) => void) => void; + all: (callback: (err: any, obj: { [sid: string]: Express.Session; }) => void) => void; + length: (callback: (err: any, length: number) => void) => void; + clear: (callback: (err: any) => void) => void; } } diff --git a/types/express-session/tsconfig.json b/types/express-session/tsconfig.json index cabddf0621..674aaf8385 100644 --- a/types/express-session/tsconfig.json +++ b/types/express-session/tsconfig.json @@ -6,7 +6,7 @@ ], "noImplicitAny": true, "noImplicitThis": true, - "strictNullChecks": true, + "strictNullChecks": false, "baseUrl": "../", "typeRoots": [ "../"