From 2d834f5b2bd0bbcec5f7c42c56efee45870af3a4 Mon Sep 17 00:00:00 2001
From: "mg.yang" <diginalog@gmail.com>
Date: Tue, 23 Jul 2019 05:26:19 +0900
Subject: [PATCH] [@types/react-js-pagination] fix getPageUrl type (#36925)

* fix getPageUrl type

* add test

* linting semicolon

linting

Co-Authored-By: Andrew M. <r3nya@ya.ru>
---
 types/react-js-pagination/index.d.ts                    | 2 +-
 types/react-js-pagination/react-js-pagination-tests.tsx | 6 +++++-
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/types/react-js-pagination/index.d.ts b/types/react-js-pagination/index.d.ts
index ee2be831e2..a0daf41111 100644
--- a/types/react-js-pagination/index.d.ts
+++ b/types/react-js-pagination/index.d.ts
@@ -33,7 +33,7 @@ export interface ReactJsPaginationProps {
     linkClassNext?: string;
     linkClassLast?: string;
     hideFirstLastPages?: boolean;
-    getPageUrl?(): string;
+    getPageUrl?: (pageNumber: number) => string;
 }
 declare const Pagination: React.ClassicComponentClass<ReactJsPaginationProps>;
 
diff --git a/types/react-js-pagination/react-js-pagination-tests.tsx b/types/react-js-pagination/react-js-pagination-tests.tsx
index d9c0a917a5..483982df24 100644
--- a/types/react-js-pagination/react-js-pagination-tests.tsx
+++ b/types/react-js-pagination/react-js-pagination-tests.tsx
@@ -8,16 +8,20 @@ class ReactPagination extends React.Component<{}, {activePage: number}> {
 			activePage: 1
 		};
 		this.handleChange = this.handleChange.bind(this);
+		this.makePageUrl = this.makePageUrl.bind(this);
 	}
 	handleChange(pageNumber: number) {
 		this.setState({
 			activePage: pageNumber
 		});
 	}
+	makePageUrl(pageNumber: number) {
+		return `#;page=${pageNumber}`;
+	}
 	render() {
         return (
             <Pagination activePage={this.state.activePage} onChange={this.handleChange}
-                totalItemsCount={100}
+                totalItemsCount={100} getPageUrl={this.makePageUrl}
             />
         );
     }