From 2e2770c2c1fc0ceb38201c669bf951d651c03cf3 Mon Sep 17 00:00:00 2001 From: Andy Date: Tue, 7 Nov 2017 09:42:02 -0800 Subject: [PATCH] Remove `// tslint:disable` comments, add TODOs to tslint.json (#21292) --- types/d3/v3/index.d.ts | 2 -- types/firebird/index.d.ts | 2 -- types/firebird/tslint.json | 5 ++++- types/oracledb/index.d.ts | 2 -- types/selenium-webdriver/v2/chrome.d.ts | 1 - types/selenium-webdriver/v2/edge.d.ts | 1 - types/selenium-webdriver/v2/executors.d.ts | 1 - types/selenium-webdriver/v2/firefox.d.ts | 1 - types/selenium-webdriver/v2/http.d.ts | 1 - types/selenium-webdriver/v2/ie.d.ts | 1 - types/selenium-webdriver/v2/index.d.ts | 1 - types/selenium-webdriver/v2/opera.d.ts | 1 - types/selenium-webdriver/v2/remote.d.ts | 1 - types/selenium-webdriver/v2/safari.d.ts | 1 - types/selenium-webdriver/v2/testing.d.ts | 1 - types/selenium-webdriver/v2/tslint.json | 19 ++++++++++++++++++- types/stack-utils/index.d.ts | 1 - types/stack-utils/tslint.json | 8 +++++++- 18 files changed, 29 insertions(+), 21 deletions(-) diff --git a/types/d3/v3/index.d.ts b/types/d3/v3/index.d.ts index 90afdd3938..0fbc7502b0 100644 --- a/types/d3/v3/index.d.ts +++ b/types/d3/v3/index.d.ts @@ -3,8 +3,6 @@ // Definitions by: Alex Ford , Boris Yankov // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped -/* tslint:disable */ - // Latest patch version of module validated against: 3.5.17 export = d3; diff --git a/types/firebird/index.d.ts b/types/firebird/index.d.ts index 771a61f706..37d88324fc 100644 --- a/types/firebird/index.d.ts +++ b/types/firebird/index.d.ts @@ -445,7 +445,6 @@ declare module 'firebird' { */ class Stream extends stream.Stream { constructor(blob: FBBlob); - /* tslint:disable */ /* NodeJS.ReadStream */ readable: boolean; @@ -462,7 +461,6 @@ declare module 'firebird' { end(str: string, encoding?: string, cb?: Function): void; destroy(error?: Error): void; - /* tslint:enable */ check_destroyed(): void; } } diff --git a/types/firebird/tslint.json b/types/firebird/tslint.json index 4b3c58f2c3..b9ced8ae6f 100644 --- a/types/firebird/tslint.json +++ b/types/firebird/tslint.json @@ -2,8 +2,11 @@ "extends": "dtslint/dt.json", "rules": { // TODO + "ban-types": false, "no-boolean-literal-compare": false, "no-declare-current-package": false, - "no-unnecessary-generics": false + "no-single-declare-module": false, + "no-unnecessary-generics": false, + "unified-signatures": false } } diff --git a/types/oracledb/index.d.ts b/types/oracledb/index.d.ts index 17ade85591..39907702dc 100644 --- a/types/oracledb/index.d.ts +++ b/types/oracledb/index.d.ts @@ -481,7 +481,6 @@ declare namespace oracledb { terminate(): IPromise; } - /* tslint:disable no-unused-variable */ const DEFAULT: number; /** Metadata return type */ const DB_TYPE_VARCHAR: number; @@ -539,7 +538,6 @@ declare namespace oracledb { */ function newLob(iLob: ILob): Lob; - /* tslint:disable no-var-keyword */ /** Default transaction behaviour of auto commit for each statement. */ var autoCommit: boolean; /** diff --git a/types/selenium-webdriver/v2/chrome.d.ts b/types/selenium-webdriver/v2/chrome.d.ts index eb7b9f13c1..ce26566f02 100644 --- a/types/selenium-webdriver/v2/chrome.d.ts +++ b/types/selenium-webdriver/v2/chrome.d.ts @@ -1,4 +1,3 @@ -/* tslint:disable */ import * as webdriver from './index'; import * as remote from './remote'; diff --git a/types/selenium-webdriver/v2/edge.d.ts b/types/selenium-webdriver/v2/edge.d.ts index 576dc01f94..b18a959700 100644 --- a/types/selenium-webdriver/v2/edge.d.ts +++ b/types/selenium-webdriver/v2/edge.d.ts @@ -1,4 +1,3 @@ -/* tslint:disable */ import * as webdriver from './index'; import * as remote from './remote'; diff --git a/types/selenium-webdriver/v2/executors.d.ts b/types/selenium-webdriver/v2/executors.d.ts index ddb3e5b752..c7bf15ef8d 100644 --- a/types/selenium-webdriver/v2/executors.d.ts +++ b/types/selenium-webdriver/v2/executors.d.ts @@ -1,4 +1,3 @@ -/* tslint:disable */ import * as webdriver from './index'; /** diff --git a/types/selenium-webdriver/v2/firefox.d.ts b/types/selenium-webdriver/v2/firefox.d.ts index 9865896ba7..7678c404ce 100644 --- a/types/selenium-webdriver/v2/firefox.d.ts +++ b/types/selenium-webdriver/v2/firefox.d.ts @@ -1,4 +1,3 @@ -/* tslint:disable */ import * as webdriver from './index'; import * as remote from './remote'; diff --git a/types/selenium-webdriver/v2/http.d.ts b/types/selenium-webdriver/v2/http.d.ts index bdb2797406..a0a25a7955 100644 --- a/types/selenium-webdriver/v2/http.d.ts +++ b/types/selenium-webdriver/v2/http.d.ts @@ -1,4 +1,3 @@ -/* tslint:disable */ import * as webdriver from './index'; /** diff --git a/types/selenium-webdriver/v2/ie.d.ts b/types/selenium-webdriver/v2/ie.d.ts index a9ae4b2c4a..9e8cab2457 100644 --- a/types/selenium-webdriver/v2/ie.d.ts +++ b/types/selenium-webdriver/v2/ie.d.ts @@ -1,4 +1,3 @@ -/* tslint:disable */ import * as webdriver from './index'; /** diff --git a/types/selenium-webdriver/v2/index.d.ts b/types/selenium-webdriver/v2/index.d.ts index 25e9e0f606..25b9b96017 100644 --- a/types/selenium-webdriver/v2/index.d.ts +++ b/types/selenium-webdriver/v2/index.d.ts @@ -3,7 +3,6 @@ // Definitions by: Bill Armstrong , Yuki Kokubun , Craig Nishina // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped // TypeScript Version: 2.1 -/* tslint:disable */ import * as chrome from './chrome'; import * as edge from './edge'; diff --git a/types/selenium-webdriver/v2/opera.d.ts b/types/selenium-webdriver/v2/opera.d.ts index 9976995e65..cd02889527 100644 --- a/types/selenium-webdriver/v2/opera.d.ts +++ b/types/selenium-webdriver/v2/opera.d.ts @@ -1,4 +1,3 @@ -/* tslint:disable */ import * as webdriver from './index'; import * as remote from './remote'; diff --git a/types/selenium-webdriver/v2/remote.d.ts b/types/selenium-webdriver/v2/remote.d.ts index de31a0fbe7..384ca521ac 100644 --- a/types/selenium-webdriver/v2/remote.d.ts +++ b/types/selenium-webdriver/v2/remote.d.ts @@ -1,4 +1,3 @@ -/* tslint:disable */ import * as webdriver from './index'; /** diff --git a/types/selenium-webdriver/v2/safari.d.ts b/types/selenium-webdriver/v2/safari.d.ts index 0633f9f782..7a6f1701c4 100644 --- a/types/selenium-webdriver/v2/safari.d.ts +++ b/types/selenium-webdriver/v2/safari.d.ts @@ -1,4 +1,3 @@ -/* tslint:disable */ import * as webdriver from './index'; export class Server { } diff --git a/types/selenium-webdriver/v2/testing.d.ts b/types/selenium-webdriver/v2/testing.d.ts index ec8e7123d7..34d72e4627 100644 --- a/types/selenium-webdriver/v2/testing.d.ts +++ b/types/selenium-webdriver/v2/testing.d.ts @@ -1,4 +1,3 @@ -/* tslint:disable */ /** * Registers a new test suite. * @param name The suite name. diff --git a/types/selenium-webdriver/v2/tslint.json b/types/selenium-webdriver/v2/tslint.json index 65c83fb1e3..3f8f8da0ad 100644 --- a/types/selenium-webdriver/v2/tslint.json +++ b/types/selenium-webdriver/v2/tslint.json @@ -1,6 +1,23 @@ { "extends": "dtslint/dt.json", "rules": { - "dt-header": false + // TODOs + "ban-types": false, + "callable-types": false, + "dt-header": false, + "interface-name": false, + "jsdoc-format": false, + "no-any-union": false, + "no-consecutive-blank-lines": false, + "no-empty-interface": false, + "no-padding": false, + "no-unnecessary-class": false, + "no-unnecessary-generics": false, + "no-redundant-jsdoc": false, + "no-redundant-jsdoc-2": false, + "no-var-keyword": false, + "semicolon": false, + "strict-export-declare-modifiers": false, + "unified-signatures": false } } diff --git a/types/stack-utils/index.d.ts b/types/stack-utils/index.d.ts index b8815641c5..f29a42298a 100644 --- a/types/stack-utils/index.d.ts +++ b/types/stack-utils/index.d.ts @@ -6,7 +6,6 @@ export = StackUtils; -// tslint:disable ban-types declare class StackUtils { static nodeInternals(): RegExp[]; constructor(options?: StackUtils.Options); diff --git a/types/stack-utils/tslint.json b/types/stack-utils/tslint.json index 3db14f85ea..3d04da382b 100644 --- a/types/stack-utils/tslint.json +++ b/types/stack-utils/tslint.json @@ -1 +1,7 @@ -{ "extends": "dtslint/dt.json" } +{ + "extends": "dtslint/dt.json", + "rules": { + // TODO + "ban-types": false + } +}