From 318e099c2e169f92f09464927e384070f1faa0c8 Mon Sep 17 00:00:00 2001 From: Benjamin Dobson Date: Thu, 17 May 2018 17:01:06 +0100 Subject: [PATCH 1/7] @types/jwplayer updated to work with JWP 8.2.2 --- types/jwplayer/index.d.ts | 20 +++++++++++++++++--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/types/jwplayer/index.d.ts b/types/jwplayer/index.d.ts index aee22c16f1..15991c7f9c 100644 --- a/types/jwplayer/index.d.ts +++ b/types/jwplayer/index.d.ts @@ -89,6 +89,12 @@ interface AdImpressionParam extends CallbackParam { wrapper: any[]; } +interface AdScheduleParam extends CallbackParam { + tag: string; + client: string; + adbreaks: Array; +} + interface AdStartedParam extends CallbackParam { creativetype: string; tag: string; @@ -287,8 +293,12 @@ interface JWPlayer { on(event: 'adRequest', callback: EventCallback): void; once(event: 'adRequest', callback: EventCallback): void; off(event: 'adRequest'): void; - trigger(event: 'adRequest', args: AdRequestParam): void; - on(event: 'adStarted', callback: EventCallback): void; + trigger(event: 'adRequest', args: AdScheduleParam): void; + on(event: 'adSchedule', callback: EventCallback): void; + once(event: 'adSchedule', callback: EventCallback): void; + off(event: 'adSchedule'): void; + trigger(event: 'adSchedule', args: AdRequestParam): void; + on(event: 'adStarted', callback: EventCallback): void; once(event: 'adStarted', callback: EventCallback): void; off(event: 'adStarted'): void; trigger(event: 'adStarted', args: AdStartedParam): void; @@ -424,7 +434,11 @@ interface JWPlayer { once(event: 'seek', callback: EventCallback): void; off(event: 'seek'): void; trigger(event: 'seek', args: SeekParam): void; - on(event: 'setupError', callback: EventCallback): void; + on(event: 'seeked', callback: () => void): void; + once(event: 'seeked', callback: () => void): void; + off(event: 'seeked'): void; + trigger(event: 'seeked'): void + on(event: 'setupError', callback: EventCallback): void; once(event: 'setupError', callback: EventCallback): void; off(event: 'setupError'): void; trigger(event: 'setupError', args: ErrorParam): void; From ee939689676ed95a1cdf5bae1926a85ce1f76269 Mon Sep 17 00:00:00 2001 From: Benjamin Dobson Date: Thu, 17 May 2018 17:17:46 +0100 Subject: [PATCH 2/7] Fixed type mismatch between adRequest and adSchedule --- types/jwplayer/index.d.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/types/jwplayer/index.d.ts b/types/jwplayer/index.d.ts index 15991c7f9c..e01620bff5 100644 --- a/types/jwplayer/index.d.ts +++ b/types/jwplayer/index.d.ts @@ -293,11 +293,11 @@ interface JWPlayer { on(event: 'adRequest', callback: EventCallback): void; once(event: 'adRequest', callback: EventCallback): void; off(event: 'adRequest'): void; - trigger(event: 'adRequest', args: AdScheduleParam): void; + trigger(event: 'adRequest', args: AdRequestParam): void; on(event: 'adSchedule', callback: EventCallback): void; once(event: 'adSchedule', callback: EventCallback): void; off(event: 'adSchedule'): void; - trigger(event: 'adSchedule', args: AdRequestParam): void; + trigger(event: 'adSchedule', args: AdScheduleParam): void; on(event: 'adStarted', callback: EventCallback): void; once(event: 'adStarted', callback: EventCallback): void; off(event: 'adStarted'): void; From fa80fda5078f458234b08d3467f5b772cfdee5fc Mon Sep 17 00:00:00 2001 From: Benjamin Dobson Date: Thu, 17 May 2018 17:20:24 +0100 Subject: [PATCH 3/7] Array style fix --- types/jwplayer/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/jwplayer/index.d.ts b/types/jwplayer/index.d.ts index e01620bff5..b2f9879d59 100644 --- a/types/jwplayer/index.d.ts +++ b/types/jwplayer/index.d.ts @@ -92,7 +92,7 @@ interface AdImpressionParam extends CallbackParam { interface AdScheduleParam extends CallbackParam { tag: string; client: string; - adbreaks: Array; + adbreaks: object[]; } interface AdStartedParam extends CallbackParam { From 5f0eecaffcc19723315a967b6c4fdde5a830fb5e Mon Sep 17 00:00:00 2001 From: Benjamin Dobson Date: Thu, 17 May 2018 17:26:31 +0100 Subject: [PATCH 4/7] object -> any in AdScheduleParam --- types/jwplayer/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/jwplayer/index.d.ts b/types/jwplayer/index.d.ts index b2f9879d59..4ab24f88cf 100644 --- a/types/jwplayer/index.d.ts +++ b/types/jwplayer/index.d.ts @@ -92,7 +92,7 @@ interface AdImpressionParam extends CallbackParam { interface AdScheduleParam extends CallbackParam { tag: string; client: string; - adbreaks: object[]; + adbreaks: any[]; } interface AdStartedParam extends CallbackParam { From 629d40c1c2548a56b19c67a36d913b5c62b06bad Mon Sep 17 00:00:00 2001 From: Benjamin Dobson Date: Thu, 17 May 2018 17:30:12 +0100 Subject: [PATCH 5/7] Updated version number in header --- types/jwplayer/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/jwplayer/index.d.ts b/types/jwplayer/index.d.ts index 4ab24f88cf..3c54446a6b 100644 --- a/types/jwplayer/index.d.ts +++ b/types/jwplayer/index.d.ts @@ -1,4 +1,4 @@ -// Type definitions for JW Player V8.0 +// Type definitions for JW Player V8.2 // Project: https://github.com/jwplayer/jwplayer/ // Definitions by: Martin Duparc // Tomer Kruvi From 1d1c5f8a6304219c715a696cc77609f9652588ab Mon Sep 17 00:00:00 2001 From: Benjamin Dobson Date: Thu, 17 May 2018 17:35:02 +0100 Subject: [PATCH 6/7] Revert "object -> any in AdScheduleParam" This reverts commit 5f0eecaffcc19723315a967b6c4fdde5a830fb5e. --- types/jwplayer/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/jwplayer/index.d.ts b/types/jwplayer/index.d.ts index 3c54446a6b..9479ea5fa1 100644 --- a/types/jwplayer/index.d.ts +++ b/types/jwplayer/index.d.ts @@ -92,7 +92,7 @@ interface AdImpressionParam extends CallbackParam { interface AdScheduleParam extends CallbackParam { tag: string; client: string; - adbreaks: any[]; + adbreaks: object[]; } interface AdStartedParam extends CallbackParam { From 62901eb27cfe85f4879b3c04a90fb030430855b5 Mon Sep 17 00:00:00 2001 From: Benjamin Dobson Date: Thu, 17 May 2018 17:44:26 +0100 Subject: [PATCH 7/7] Add my name and minimum typescript version --- types/jwplayer/index.d.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/types/jwplayer/index.d.ts b/types/jwplayer/index.d.ts index 9479ea5fa1..6481b59faf 100644 --- a/types/jwplayer/index.d.ts +++ b/types/jwplayer/index.d.ts @@ -4,7 +4,9 @@ // Tomer Kruvi // Philipp Gürtler // Daniel McGraw +// Benjamin Dobson // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped +// TypeScript Version: 2.2 // JW Player is the leading HTML5 & Flash video player, optimized for mobile and the desktop. Easy enough for beginners, advanced enough for pros.