From cc01b622739263f8871de60503be4a5c83a941ae Mon Sep 17 00:00:00 2001 From: Jose Colella Date: Wed, 13 Jun 2018 10:58:35 -0400 Subject: [PATCH 1/3] Add optional family type to CoreOptions. References issue https://github.com/request/request-promise-native/issues/6 --- types/request/index.d.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/types/request/index.d.ts b/types/request/index.d.ts index 71f41ff794..f9ee41842b 100644 --- a/types/request/index.d.ts +++ b/types/request/index.d.ts @@ -139,6 +139,7 @@ declare namespace request { method?: string; headers?: Headers; body?: any; + family?: number; followRedirect?: boolean | ((response: http.IncomingMessage) => boolean); followAllRedirects?: boolean; followOriginalHttpMethod?: boolean; From 6ee3480792a0df733e2e4bc28a1729c7738a6140 Mon Sep 17 00:00:00 2001 From: Jose Colella Date: Wed, 13 Jun 2018 11:22:18 -0400 Subject: [PATCH 2/3] Add name and github link to definitionsby --- types/request/index.d.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/types/request/index.d.ts b/types/request/index.d.ts index f9ee41842b..51cb7919a7 100644 --- a/types/request/index.d.ts +++ b/types/request/index.d.ts @@ -7,6 +7,7 @@ // Christopher Currens , // Jon Stevens , // Matt R. Wilson +// Jose Colella // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped // TypeScript Version: 2.3 From a51018316fabe2535d860584cbabf0b2ad97c2bd Mon Sep 17 00:00:00 2001 From: Jose Colella Date: Thu, 14 Jun 2018 08:22:34 -0400 Subject: [PATCH 3/3] Restrict optional family value to 4 or 6. References IPv4 and IPv6 --- types/request/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/request/index.d.ts b/types/request/index.d.ts index 51cb7919a7..60e24b7692 100644 --- a/types/request/index.d.ts +++ b/types/request/index.d.ts @@ -140,7 +140,7 @@ declare namespace request { method?: string; headers?: Headers; body?: any; - family?: number; + family?: 4 | 6; followRedirect?: boolean | ((response: http.IncomingMessage) => boolean); followAllRedirects?: boolean; followOriginalHttpMethod?: boolean;