From 4a3fa500862e45028bee41eb57bd2ee89e4e3c59 Mon Sep 17 00:00:00 2001 From: Lance Austin Date: Wed, 22 Mar 2017 15:20:19 -0500 Subject: [PATCH 1/4] Fix DialogOptions Interface --- types/office-js/index.d.ts | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/types/office-js/index.d.ts b/types/office-js/index.d.ts index 8dc027f765..e6db11fcce 100644 --- a/types/office-js/index.d.ts +++ b/types/office-js/index.d.ts @@ -1,6 +1,6 @@ // Type definitions for Office.js // Project: http://dev.office.com -// Definitions by: OfficeDev +// Definitions by: OfficeDev , Lance Austin // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped /* @@ -111,6 +111,10 @@ declare namespace Office { * Optional. Determines whether the dialog is safe to display within a Web frame. */ xFrameDenySafe?: boolean, + /** + * Optional. Determines whether the dialog box should be displayed within an IFrame. This setting is only applicable in Office Online clients, this setting is ignored by desktop clients. + */ + displayInIframe?: boolean } export interface OfficeTheme { bodyBackgroundColor: string; From 7f7e6e8210a6ff3e22510c67fcacff1079e170c4 Mon Sep 17 00:00:00 2001 From: Lance Austin Date: Wed, 22 Mar 2017 19:14:23 -0500 Subject: [PATCH 2/4] Office-JS: Removed xFrameDenySave from DialogOptions --- types/office-js/index.d.ts | 4 ---- 1 file changed, 4 deletions(-) diff --git a/types/office-js/index.d.ts b/types/office-js/index.d.ts index e6db11fcce..597e6552a8 100644 --- a/types/office-js/index.d.ts +++ b/types/office-js/index.d.ts @@ -107,10 +107,6 @@ declare namespace Office { * Optional. Defines the height of the dialog as a percentage of the current display. Defaults to 99%. 150px minimum. */ width?: number, - /** - * Optional. Determines whether the dialog is safe to display within a Web frame. - */ - xFrameDenySafe?: boolean, /** * Optional. Determines whether the dialog box should be displayed within an IFrame. This setting is only applicable in Office Online clients, this setting is ignored by desktop clients. */ From 0f17702167b8f5946fefe908d6500389804bdd8f Mon Sep 17 00:00:00 2001 From: Lance Austin Date: Fri, 24 Mar 2017 15:10:52 -0500 Subject: [PATCH 3/4] Updated Grammer --- types/office-js/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/office-js/index.d.ts b/types/office-js/index.d.ts index 597e6552a8..025d521478 100644 --- a/types/office-js/index.d.ts +++ b/types/office-js/index.d.ts @@ -108,7 +108,7 @@ declare namespace Office { */ width?: number, /** - * Optional. Determines whether the dialog box should be displayed within an IFrame. This setting is only applicable in Office Online clients, this setting is ignored by desktop clients. + * Optional. Determines whether the dialog box should be displayed within an IFrame. This setting is only applicable in Office Online clients, and is ignored on the platforms. */ displayInIframe?: boolean } From 8c2b1608deeb05eeaf365502f3eb69d16dde23d4 Mon Sep 17 00:00:00 2001 From: Lance Austin Date: Sun, 26 Mar 2017 10:57:22 -0500 Subject: [PATCH 4/4] Rebased on upstream and matched grammar to Office Dev Docs --- types/office-js/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/office-js/index.d.ts b/types/office-js/index.d.ts index 025d521478..13329dad9b 100644 --- a/types/office-js/index.d.ts +++ b/types/office-js/index.d.ts @@ -108,7 +108,7 @@ declare namespace Office { */ width?: number, /** - * Optional. Determines whether the dialog box should be displayed within an IFrame. This setting is only applicable in Office Online clients, and is ignored on the platforms. + * Optional. Determines whether the dialog box should be displayed within an IFrame. This setting is only applicable in Office Online clients, and is ignored on other platforms. */ displayInIframe?: boolean }