From 302ef7b926ace5e05e376e59611d206a7fa14c7d Mon Sep 17 00:00:00 2001 From: Abram Booth Date: Tue, 17 Apr 2018 21:11:52 -0400 Subject: [PATCH] Fix EmberArray.uniqBy typing (#25073) --- types/ember/index.d.ts | 2 +- types/ember/test/array-ext.ts | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/types/ember/index.d.ts b/types/ember/index.d.ts index cd4ba0f85f..aeb05d115d 100755 --- a/types/ember/index.d.ts +++ b/types/ember/index.d.ts @@ -1243,7 +1243,7 @@ declare module 'ember' { * Returns a new enumerable that contains only items containing a unique property value. * The default implementation returns an array regardless of the receiver type. */ - uniqBy(): NativeArray; + uniqBy(property: string): NativeArray; /** * Returns `true` if the passed object can be found in the enumerable. */ diff --git a/types/ember/test/array-ext.ts b/types/ember/test/array-ext.ts index 86e84fd7c5..059d60c00c 100755 --- a/types/ember/test/array-ext.ts +++ b/types/ember/test/array-ext.ts @@ -16,3 +16,6 @@ assertType(array.get('length')); assertType(array.get('firstObject')); assertType(array.mapBy('name')); assertType(array.map(p => p.get('name'))); +assertType(array.sortBy('name')); +assertType(array.uniq()); +assertType(array.uniqBy('name'));