From 329c092b7e3abde88ded597e8fba968c6d3cc312 Mon Sep 17 00:00:00 2001 From: Luka Maljic Date: Wed, 13 Dec 2017 10:13:46 +0100 Subject: [PATCH] Fixed dtslint warnings --- types/koa-webpack/index.d.ts | 35 ++++++++++++-------------- types/koa-webpack/koa-webpack-tests.ts | 27 +++++++++----------- types/koa-webpack/tsconfig.json | 1 + 3 files changed, 29 insertions(+), 34 deletions(-) diff --git a/types/koa-webpack/index.d.ts b/types/koa-webpack/index.d.ts index 363c9cb5b0..4a598d3ac5 100644 --- a/types/koa-webpack/index.d.ts +++ b/types/koa-webpack/index.d.ts @@ -3,31 +3,28 @@ // Definitions by: Luka Maljic // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped -import * as Koa from 'koa' -import * as webpack from 'webpack' -import * as webpackDevMiddleware from 'webpack-dev-middleware' -import * as webpackHotMiddleware from 'webpack-hot-middleware' -import { NextHandleFunction } from 'connect' +import * as Koa from 'koa'; +import * as webpack from 'webpack'; +import * as webpackDevMiddleware from 'webpack-dev-middleware'; +import * as webpackHotMiddleware from 'webpack-hot-middleware'; +import { NextHandleFunction } from 'connect'; declare function koaWebpack( options?: koaWebpack.Options -): Koa.Middleware & koaWebpack.CombinedWebpackMiddleware +): Koa.Middleware & koaWebpack.CombinedWebpackMiddleware; -declare namespace koaWebpack -{ - interface Options - { - compiler?: webpack.Compiler - config?: webpack.Configuration - dev?: webpackDevMiddleware.Options - hot?: webpackHotMiddleware.Options +declare namespace koaWebpack { + interface Options { + compiler?: webpack.Compiler; + config?: webpack.Configuration; + dev?: webpackDevMiddleware.Options; + hot?: webpackHotMiddleware.Options; } - interface CombinedWebpackMiddleware - { - dev: NextHandleFunction & webpackDevMiddleware.WebpackDevMiddleware - hot: NextHandleFunction & webpackHotMiddleware.EventStream + interface CombinedWebpackMiddleware { + dev: NextHandleFunction & webpackDevMiddleware.WebpackDevMiddleware; + hot: NextHandleFunction & webpackHotMiddleware.EventStream; } } -export = koaWebpack +export = koaWebpack; diff --git a/types/koa-webpack/koa-webpack-tests.ts b/types/koa-webpack/koa-webpack-tests.ts index eaa3468ce1..235bb67056 100644 --- a/types/koa-webpack/koa-webpack-tests.ts +++ b/types/koa-webpack/koa-webpack-tests.ts @@ -1,11 +1,10 @@ -import * as Koa from 'koa' -import * as webpack from 'webpack' -import * as koaWebpack from 'koa-webpack' - -const app = new Koa() -const config: webpack.Configuration = {} -const compiler = webpack(config) +import * as Koa from 'koa'; +import * as webpack from 'webpack'; +import * as koaWebpack from 'koa-webpack'; +const app = new Koa(); +const config: webpack.Configuration = {}; +const compiler = webpack(config); // Using the middleware @@ -36,15 +35,13 @@ const middleware = koaWebpack({ path: '/__what', heartbeat: 2000 } -}) - -app.use(middleware) +}); +app.use(middleware); // Accessing the underlying middleware -middleware.dev.close() -middleware.dev.invalidate() -middleware.dev.waitUntilValid() -middleware.hot.publish(null) - +middleware.dev.close(); +middleware.dev.invalidate(); +middleware.dev.waitUntilValid(); +middleware.hot.publish(null); diff --git a/types/koa-webpack/tsconfig.json b/types/koa-webpack/tsconfig.json index 57a4aac117..d3cef374db 100644 --- a/types/koa-webpack/tsconfig.json +++ b/types/koa-webpack/tsconfig.json @@ -7,6 +7,7 @@ "noImplicitAny": true, "noImplicitThis": true, "strictNullChecks": true, + "strictFunctionTypes": true, "baseUrl": "../", "typeRoots": [ "../"