From e5122de079e2ad9d05753e04e46ad48379424b9f Mon Sep 17 00:00:00 2001 From: Matt Gibbs Date: Thu, 24 Sep 2015 10:36:22 -0400 Subject: [PATCH 1/2] Added showOn function to IShepherdTourStepOptions Also bumped documented version to 1.2.0 --- tether-shepherd/tether-shepherd.d.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tether-shepherd/tether-shepherd.d.ts b/tether-shepherd/tether-shepherd.d.ts index eeee871044..413d569ed7 100644 --- a/tether-shepherd/tether-shepherd.d.ts +++ b/tether-shepherd/tether-shepherd.d.ts @@ -1,4 +1,4 @@ -// Type definitions for Tether-Shepherd v1.1.2 +// Type definitions for Tether-Shepherd v1.2.0 // Project: http://github.hubspot.com/shepherd/ // Definitions by: Matt Gibbs // Definitions: https://github.com/borisyankov/DefinitelyTyped @@ -149,6 +149,7 @@ declare module TetherShepherd { showCancelLink?: boolean; scrollTo?: boolean; when?: any; + showOn?: () => boolean; // TODO: Tie this in with the tether.d.ts tetherOptions?: any; From 0e38df00b808f14829271f4db06c97d4718186c4 Mon Sep 17 00:00:00 2001 From: Matt Gibbs Date: Thu, 24 Sep 2015 10:41:31 -0400 Subject: [PATCH 2/2] Added test for compiling showOn --- tether-shepherd/tether-shepherd-tests.ts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tether-shepherd/tether-shepherd-tests.ts b/tether-shepherd/tether-shepherd-tests.ts index 7325a84647..085da575b9 100644 --- a/tether-shepherd/tether-shepherd-tests.ts +++ b/tether-shepherd/tether-shepherd-tests.ts @@ -46,6 +46,9 @@ var step2Options: TetherShepherd.IShepherdTourStepOptions = { destroy: () => { console.log('Destroyed the Step 2'); } + }, + showOn: () => { + return true; } }; @@ -55,4 +58,4 @@ var queriedStep = tour.getById('test-step-2'); queriedStep.destroy(); -tour.start(); \ No newline at end of file +tour.start();