From 35feaab6aed2b359e5c520f036d9dcf6f7d9dff6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Piotr=20B=C5=82a=C5=BCejewicz=20=28Peter=20Blazejewicz=29?= Date: Fri, 3 Jan 2020 21:50:19 +0100 Subject: [PATCH] fix(truncate-middle): null union type for `str` (#41277) This fixes empty string return when param equals `null`: https://git.io/JeNkz Thanks! --- types/truncate-middle/index.d.ts | 2 +- types/truncate-middle/truncate-middle-tests.ts | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/types/truncate-middle/index.d.ts b/types/truncate-middle/index.d.ts index ec4f3e52e7..9758d4435c 100644 --- a/types/truncate-middle/index.d.ts +++ b/types/truncate-middle/index.d.ts @@ -3,6 +3,6 @@ // Definitions by: Gary King // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped -declare function truncateMiddle(text: string, frontLength?: number, backLength?: number, ellipsis?: string): string; +declare function truncateMiddle(text: string | null, frontLength?: number, backLength?: number, ellipsis?: string): string; export = truncateMiddle; diff --git a/types/truncate-middle/truncate-middle-tests.ts b/types/truncate-middle/truncate-middle-tests.ts index 9bb60ee7d1..eb1b28a776 100644 --- a/types/truncate-middle/truncate-middle-tests.ts +++ b/types/truncate-middle/truncate-middle-tests.ts @@ -7,3 +7,5 @@ truncateMiddle('text', 1); truncateMiddle('text', 1, 2); truncateMiddle('text', 1, 2, '...'); + +truncateMiddle(null);